Skip to content

Commit

Permalink
Fix infinite loop (#42228) (#42293)
Browse files Browse the repository at this point in the history
## Summary

Fixes infinite loop when machine learning create job returns an error

https://github.com/elastic/ingest-dev/issues/616

This now will show an error toaster pop up which acts as a circuit breaker and does not continuously hit the back end if you have create job errors such as this one:

<img width="791" alt="Screen Shot 2019-07-29 at 11 22 39 PM" src="https://user-images.githubusercontent.com/1151048/62103608-293a5400-b25a-11e9-9a9d-a5af42f7e128.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
  • Loading branch information
FrankHassanabad authored Jul 30, 2019
1 parent 0a861ca commit 9be59c0
Show file tree
Hide file tree
Showing 5 changed files with 306 additions and 7 deletions.
Loading

0 comments on commit 9be59c0

Please sign in to comment.