Field formatting

[spalger]

Fixes #2882

Prereq PRs:

• [config] added simple $bind helper #3640
• Percentile and value ui combo #3518
• Tweak hit flattening #3577
• [$multiWatch] simplified the code and fixed a race condition #3685
• [vislib/pointSeries] support specifying a yAxisFormatter #3704

This PR adds an initial implementation of field formatters. The default formats are defined in the "stringify" module, and registered with the registry/field_formats registry. The formats registered with the registry declare their type compatibility, which makes them an option when choosing the format for a particular field.

Every field type has a default field format, which is defined in the defaultFieldFormats config variable. This variable defines the default format for field types, but also a default for the default.

Modifying the format for a field is done within the index pattern settings. In the field table, a new format column shows the name of the format in use for that field. Clicking the cell reveals a select box, which when changed will update the format specified for that field. Choosing the - default - setting will cause that field to once again inherit the default format for that field type.

The non-default format names for each field are stored in the fieldFormatMap property on the indexPattern object, helping format names persist across field-list refreshes.

[w33ble]

LGTM now that that's fixed!

[simianhacker]

I have data where my schema is basically { name: 'nameOfMetric', value: 129929 } and I wanted to have format value multiple ways (bytes, currency, number, etc). My work around was to use scripted fields where I would just create valueAsBytes, valueAsMoney, etc... Upon trying this out I found a bug:

[simianhacker]

I thought there was suppose to be a way to add my own Numeral.js formatting pattern with the "Number" formatter? Did you remove that?

[lukasolson]

Looks to me like scripted fields are now showing up in the regular field list, and when I click on the trash icon to delete them, it doesn't actually work.

[spalger]

@lukasolson @simianhacker those issues are fixed.

[tbragin]

Long numbers on the Y-axis seem to run off screen. I also still don't understand why we don't update the dates on the X-axis when the timestamp field has been formatted (mine is formatted as "MMMM Do YYYY"

What is the point of this formatting option? I'm not clear on what it does.

I'm not sure this is the most useful way to visualize a number formatted as a URL in a metric vis and legends, e.g. pie vis? I don't necessarily have a better suggestion other than either not formatting it as a URL in those instances or showing only the original value only (in this case the HTTP status code) and making it clickable? But that could be ugly.

[spalger]

@tbragin:

1. check out Flexible y-axis styling #2693 for the y-axis issue
2. this is what renders the "field: value" cloud in discover. Today it doesn't have any parameters but tomorrow it very well may.
3. Opened Url field formats need an alt template #3747 to solve this outside of this pull.

[simianhacker]

I'm not finding any issues with this so I'm going to give it my ceremonial LGETM. Congrats! 💃 💃 💃

[spalger]

🍭 yummy

[panda01]

I find myself hard pressed to find more issues with this. Great job man. LGTM.

[fcroiseaux]

Can we change the language used for formatting numbers ? I didn't find how.

2015-05-05 0:09 GMT+02:00 Khalah Jones Golden notifications@github.com:

I find myself hard pressed to find more issues with this. Great job man.
LGTM.

—
Reply to this email directly or view it on GitHub
#2731 (comment).

[dagguh]

Percentile values are formatted as percents:

They should be formatted as numbers.
Tested on 637a3ee

PS. The Y-Axis is clipped.