Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten hits #2723

Merged
merged 18 commits into from
Apr 8, 2015
Merged

Flatten hits #2723

merged 18 commits into from
Apr 8, 2015

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 22, 2015

This slightly modifies the way that hits are flattened:

  • computed fields are unwrapped as a part of flattening
  • unified flattenHit and flattenSearchResponse
  • moves all cache management into flattenHit, removes it from several places in discover.

Spencer Alger added 12 commits January 21, 2015 23:17
[indexPattern/flattenHit] pass indexPattern as an arg, don't force .b…
1df7942 
…ind()
[indexPatterns/flattenSearchResponse] pass indexPattern as an arg, do…
1510e2a 
…n't force .bind()
[indexPatterns/flattenSearchResponse] update tests
90b0c88
[indexPattern/flattenHit] simplify logic with a lodash chain
9eed7bb
[indexPattern/flattenSearchResponse] unwrap scripted field values whe…
0cf92ac 
…n flattening
[indexPattern] update method signature
7232a35
[indexPattern/flattenSearchResponse] update tests
fa6dbca
[stubbedIndexPattern] update flatten* signatures
85cadb8
[indexPattern/flattenHit] further simplify by merging with flattenSea…
f977929 
…rchResponse
[indexPattern/flattenHit] update tests
b26a473
remove some unneeded caching
6c5e668
[indexPattern/flattenHit] change write order so that _source doesn't …
d378058 
…show up first by default
@spalger spalger added the review label Jan 22, 2015
@rashidkpc
Copy link
Contributor

This LGTM. Is it needed for some other pull?

@rashidkpc rashidkpc assigned spalger and unassigned rashidkpc Jan 26, 2015
@spalger
Copy link
Contributor Author

spalger commented Jan 26, 2015

@rashidkpc yep, for #2731

@rashidkpc
Copy link
Contributor

Since #2731 is still a work in progress, and we're in bug-fix mode, lets hold on this.

@spalger spalger modified the milestone: 4.1.0 Jan 28, 2015
@rashidkpc rashidkpc removed the review label Jan 29, 2015
@rashidkpc rashidkpc modified the milestone: 4.1.0 Feb 13, 2015
@rashidkpc rashidkpc modified the milestone: 4.1.0 Mar 2, 2015
@jdve jdve mentioned this pull request Mar 28, 2015
Closed
@spalger spalger assigned rashidkpc and unassigned spalger Apr 2, 2015
@rashidkpc
Copy link
Contributor

Still LGTM, fix the linting and merge it.

rashidkpc added a commit that referenced this pull request Apr 8, 2015
@rashidkpc
Merge pull request #2723 from spalger/flattenHits
8a92924 
Flatten hits
@rashidkpc rashidkpc merged commit 8a92924 into elastic:master Apr 8, 2015
@spalger spalger mentioned this pull request Apr 10, 2015
Merged
@jdve jdve mentioned this pull request Apr 13, 2015
Merged
@spalger spalger deleted the flattenHits branch July 31, 2015 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rashidkpc rashidkpc

Labels
review v4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalger @rashidkpc