[indexPattern/flattenSearchResponse] flatten conflicting objects #3584
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing |
When flattening hits containing conflicting types, continue to recursively flatten the object if possible, rather than simply ending with a complex object. This fixes a problem when a conflicting type effectively "hides" nested fields. For example, if "a" is conflicted (because sometimes it's an object and sometimes it's a native value), without this change "a.x" will be hidden from the results, even though it's only an object-level conflict. The "a.x" field itself should appear in the flatten hit as a separate field.
|
@rashidkpc all fixed |
|
LGTM! Thanks @jdve! |
spalger
added a commit
that referenced
this pull request
Apr 15, 2015
[indexPattern/flattenSearchResponse] flatten conflicting objects
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When flattening hits containing conflicting types, continue to
recursively flatten the object if possible, rather than simply ending
with a complex object. This fixes a problem when a conflicting type
effectively "hides" nested fields. For example, if "a" is conflicted
(because sometimes it's an object and sometimes it's a native value),
without this change "a.x" will be hidden from the results, even though
it's only an object-level conflict. The "a.x" field itself should
appear in the flatten hit as a separate field.
Rebased version of #3457 after #2723 (sorry, accidentally deleted my original project).
/cc @rashidkpc, @spalger