[config] added simple $bind helper #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you write a test for this? I know its a small thing, but I can see it being used widely. |
|
Tests added |
|
Oooh and bonus tests for config in general 👍 Merge master and LGTM. |
rashidkpc
added a commit
that referenced
this pull request
Apr 28, 2015
[config] added simple $bind helper
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 10, 2024
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2731 I needed to replicate this behavior so I pushed it into the config component so it could be shared.