Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url label format #3748

Merged
merged 3 commits into from
May 6, 2015
Merged

Url label format #3748

merged 3 commits into from
May 6, 2015

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 4, 2015

Fixes: #3747

Adds a template to Url formatters that allows customizing the content of the link tag.

image

@lukasolson
Copy link
Member

This looks good. My only feedback would be to provide an example in the help boxes of how to use the double curly brackets to utilize value or rawValue. But meh. If you want someone else to take a look, feel free to assign it. Otherwise, go ahead and merge.

@lukasolson lukasolson assigned spalger and unassigned lukasolson May 5, 2015
@spalger
Copy link
Contributor Author

spalger commented May 6, 2015

Added some help text. What do you think?

image

spalger added a commit that referenced this pull request May 6, 2015
@spalger spalger merged commit f5eac5d into elastic:master May 6, 2015
@pagenbag
Copy link

Can we please have an option to exclude the target="_blank" on the links ? Or to be able to specify it.
When using the dashboards or visualizations in shared/embeded in an iframe - it makes sense to be able to redirect the page/iframe instead of opening a new tab each time.

@spalger spalger deleted the urlLabelFormat branch July 31, 2015 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Url field formats need an alt template
3 participants