Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [Security Solution] Copies over settings from timeline template (#190511) #190530

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…tic#190511)

## Summary

Handles : elastic#189992

When user had created a timeline template and attached it to the rule,
the columns were not being copied over from template to the timeline
created from the alert generated by same rule.

This PR fixes that as shown in demo below :

https://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8

> [!Caution]
> This PR checks below objects that are needed to be copied over from
template
> - columns
> - data providers
>
> If we think, more things should be copied over, please comment below.

## Test Results

![grafik](https://github.com/user-attachments/assets/ad527eda-a1c2-49f0-bcfe-0ea449c29b34)

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit a13f8d9)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 17.2MB 17.2MB +380.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 550 551 +1

Total ESLint disabled count

id before after diff
securitySolution 633 634 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @logeekal

@kibanamachine kibanamachine merged commit f0c5801 into elastic:8.15 Aug 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants