[Security Solution] Copies over settings from timeline template #190511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
| @@ -160,7 +170,7 @@ export const useInvestigateInTimeline = ({ | |||
| notes: [], | |||
| timeline: { | |||
| ...timeline, | |||
| columns: !unifiedComponentsInTimelineDisabled ? defaultUdtHeaders : defaultHeaders, | |||
There was a problem hiding this comment.
so this was only broken by introduction of this feature flag?
There was a problem hiding this comment.
No it was broken in 8.14 as well and becuase of that this feature flag replaced that broken code and produced same output.
There was a problem hiding this comment.
Actually, I retract my statement. Yes unified components changes broke it but initial feature flag was introduced in 8.14 and that is why it was broken in 8.14 also.
kqualters-elastic
approved these changes
Aug 14, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 14, 2024
…tic#190511) ## Summary Handles : elastic#189992 When user had created a timeline template and attached it to the rule, the columns were not being copied over from template to the timeline created from the alert generated by same rule. This PR fixes that as shown in demo below : https://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8 > [!Caution] > This PR checks below objects that are needed to be copied over from template > - columns > - data providers > > If we think, more things should be copied over, please comment below. ## Test Results  ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a13f8d9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 14, 2024
#190511) (#190530) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution] Copies over settings from timeline template (#190511)](#190511) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-08-14T16:27:14Z","message":"[Security Solution] Copies over settings from timeline template (#190511)\n\n## Summary\r\n\r\nHandles : https://github.com/elastic/kibana/issues/189992\r\n\r\nWhen user had created a timeline template and attached it to the rule,\r\nthe columns were not being copied over from template to the timeline\r\ncreated from the alert generated by same rule.\r\n\r\nThis PR fixes that as shown in demo below : \r\n\r\n\r\nhttps://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8\r\n\r\n> [!Caution]\r\n> This PR checks below objects that are needed to be copied over from\r\ntemplate\r\n> - columns\r\n> - data providers\r\n>\r\n> If we think, more things should be copied over, please comment below.\r\n\r\n## Test Results\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a13f8d983c38736478f2430efa090fedb1c50784","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","backport:prev-minor","v8.16.0","v8.15.1"],"title":"[Security Solution] Copies over settings from timeline template","number":190511,"url":"https://github.com/elastic/kibana/pull/190511","mergeCommit":{"message":"[Security Solution] Copies over settings from timeline template (#190511)\n\n## Summary\r\n\r\nHandles : https://github.com/elastic/kibana/issues/189992\r\n\r\nWhen user had created a timeline template and attached it to the rule,\r\nthe columns were not being copied over from template to the timeline\r\ncreated from the alert generated by same rule.\r\n\r\nThis PR fixes that as shown in demo below : \r\n\r\n\r\nhttps://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8\r\n\r\n> [!Caution]\r\n> This PR checks below objects that are needed to be copied over from\r\ntemplate\r\n> - columns\r\n> - data providers\r\n>\r\n> If we think, more things should be copied over, please comment below.\r\n\r\n## Test Results\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a13f8d983c38736478f2430efa090fedb1c50784"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190511","number":190511,"mergeCommit":{"message":"[Security Solution] Copies over settings from timeline template (#190511)\n\n## Summary\r\n\r\nHandles : https://github.com/elastic/kibana/issues/189992\r\n\r\nWhen user had created a timeline template and attached it to the rule,\r\nthe columns were not being copied over from template to the timeline\r\ncreated from the alert generated by same rule.\r\n\r\nThis PR fixes that as shown in demo below : \r\n\r\n\r\nhttps://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8\r\n\r\n> [!Caution]\r\n> This PR checks below objects that are needed to be copied over from\r\ntemplate\r\n> - columns\r\n> - data providers\r\n>\r\n> If we think, more things should be copied over, please comment below.\r\n\r\n## Test Results\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a13f8d983c38736478f2430efa090fedb1c50784"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handles : #189992
When user had created a timeline template and attached it to the rule, the columns were not being copied over from template to the timeline created from the alert generated by same rule.
This PR fixes that as shown in demo below :
timeline_columns_copy_fix.mp4
Caution
This PR checks below objects that are needed to be copied over from template
If we think, more things should be copied over, please comment below.
Test Results
Checklist
Delete any items that are not applicable to this PR.