Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Columns are not copied over from Timeline Template on Investigate in Timeline #189992

Closed
logeekal opened this issue Aug 6, 2024 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timeline Security Solution Timeline feature impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team

Comments

@logeekal
Copy link
Contributor

logeekal commented Aug 6, 2024

Describe the bug:
Columns from Timeline template are not copied over when user clicks on Investigate In Timeline

Kibana/Elasticsearch Stack version:
8.14, 8.15

Steps to reproduce:

  1. Create a Timeline template with custom columns set
  2. Create Rule and attach template to the rule.
  3. Load the data such that above rule creates alerts.
  4. Click on Investigate in timeline.
  5. List of columns will not be same as Timeline template created in Step 1

Current behavior:
List of columns will not be same as Timeline template.

Expected behavior:
List of columns should be same as Timeline template.

@logeekal logeekal added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Aug 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@logeekal logeekal added the Team:Threat Hunting:Investigations Security Solution Investigations Team label Aug 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@logeekal logeekal added the Feature:Timeline Security Solution Timeline feature label Aug 6, 2024
@michaelolo24 michaelolo24 added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed triage_needed labels Aug 13, 2024
logeekal added a commit that referenced this issue Aug 14, 2024
)

## Summary

Handles : #189992

When user had created a timeline template and attached it to the rule,
the columns were not being copied over from template to the timeline
created from the alert generated by same rule.

This PR fixes that as shown in demo below : 


https://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8

> [!Caution]
> This PR checks below objects that are needed to be copied over from
template
> - columns
> - data providers
>
> If we think, more things should be copied over, please comment below.

## Test Results


![grafik](https://github.com/user-attachments/assets/ad527eda-a1c2-49f0-bcfe-0ea449c29b34)



### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 14, 2024
…tic#190511)

## Summary

Handles : elastic#189992

When user had created a timeline template and attached it to the rule,
the columns were not being copied over from template to the timeline
created from the alert generated by same rule.

This PR fixes that as shown in demo below :

https://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8

> [!Caution]
> This PR checks below objects that are needed to be copied over from
template
> - columns
> - data providers
>
> If we think, more things should be copied over, please comment below.

## Test Results

![grafik](https://github.com/user-attachments/assets/ad527eda-a1c2-49f0-bcfe-0ea449c29b34)

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit a13f8d9)
kibanamachine referenced this issue Aug 14, 2024
#190511) (#190530)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Security Solution] Copies over settings from timeline template
(#190511)](#190511)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-08-14T16:27:14Z","message":"[Security
Solution] Copies over settings from timeline template (#190511)\n\n##
Summary\r\n\r\nHandles :
https://github.com/elastic/kibana/issues/189992\r\n\r\nWhen user had
created a timeline template and attached it to the rule,\r\nthe columns
were not being copied over from template to the timeline\r\ncreated from
the alert generated by same rule.\r\n\r\nThis PR fixes that as shown in
demo below :
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8\r\n\r\n>
[!Caution]\r\n> This PR checks below objects that are needed to be
copied over from\r\ntemplate\r\n> - columns\r\n> - data
providers\r\n>\r\n> If we think, more things should be copied over,
please comment below.\r\n\r\n## Test
Results\r\n\r\n\r\n![grafik](https://github.com/user-attachments/assets/ad527eda-a1c2-49f0-bcfe-0ea449c29b34)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a13f8d983c38736478f2430efa090fedb1c50784","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","backport:prev-minor","v8.16.0","v8.15.1"],"title":"[Security
Solution] Copies over settings from timeline
template","number":190511,"url":"https://github.com/elastic/kibana/pull/190511","mergeCommit":{"message":"[Security
Solution] Copies over settings from timeline template (#190511)\n\n##
Summary\r\n\r\nHandles :
https://github.com/elastic/kibana/issues/189992\r\n\r\nWhen user had
created a timeline template and attached it to the rule,\r\nthe columns
were not being copied over from template to the timeline\r\ncreated from
the alert generated by same rule.\r\n\r\nThis PR fixes that as shown in
demo below :
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8\r\n\r\n>
[!Caution]\r\n> This PR checks below objects that are needed to be
copied over from\r\ntemplate\r\n> - columns\r\n> - data
providers\r\n>\r\n> If we think, more things should be copied over,
please comment below.\r\n\r\n## Test
Results\r\n\r\n\r\n![grafik](https://github.com/user-attachments/assets/ad527eda-a1c2-49f0-bcfe-0ea449c29b34)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a13f8d983c38736478f2430efa090fedb1c50784"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190511","number":190511,"mergeCommit":{"message":"[Security
Solution] Copies over settings from timeline template (#190511)\n\n##
Summary\r\n\r\nHandles :
https://github.com/elastic/kibana/issues/189992\r\n\r\nWhen user had
created a timeline template and attached it to the rule,\r\nthe columns
were not being copied over from template to the timeline\r\ncreated from
the alert generated by same rule.\r\n\r\nThis PR fixes that as shown in
demo below :
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4237672e-943a-43f9-b160-5449399a5fd8\r\n\r\n>
[!Caution]\r\n> This PR checks below objects that are needed to be
copied over from\r\ntemplate\r\n> - columns\r\n> - data
providers\r\n>\r\n> If we think, more things should be copied over,
please comment below.\r\n\r\n## Test
Results\r\n\r\n\r\n![grafik](https://github.com/user-attachments/assets/ad527eda-a1c2-49f0-bcfe-0ea449c29b34)\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"a13f8d983c38736478f2430efa090fedb1c50784"}},{"branch":"8.15","label":"v8.15.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
@logeekal
Copy link
Contributor Author

Fixed with #190511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timeline Security Solution Timeline feature impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team
Projects
None yet
Development

No branches or pull requests

3 participants