Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Serverless navigation #153777

Closed
5 tasks done
sorenlouv opened this issue Mar 27, 2023 · 25 comments · Fixed by #160620
Closed
5 tasks done

[Observability] Serverless navigation #153777

sorenlouv opened this issue Mar 27, 2023 · 25 comments · Fixed by #160620
Assignees
Labels

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Mar 27, 2023

On Serverless we want to display a dedicated Observability nav instead of the existing nav.

Links:

Implementation details
The menu should be registered via serverless.oblt.yml.
Existing implementations of serverless nav:

Kibana can be started in serverless mode with:

yarn start --serverless=oblt

image

View more screens

image

image

image

Observability navigation item list

Label Link Extra
Discover /app/discover
Dashboards /app/dashboards
Alerts /app/alerts
SLOs /app/slos
AIOps /app/aiops/anomaly-detection Group of nav items, collapsed by default
⮑ Anomaly detection /app/aiops/anomaly-detection
⮑ Spike analysis /app/aiops/spike-analysis Tech preview badge
⮑ Change point detection /app/aiops/change-point-detection Tech preview badge
⮑ Job notifications /app/aiops/job-notifications
Applications /app/applications/services Group of nav items, collapsed by default
⮑ Services /app/applications/services
⮑ Traces /app/applications/traces
⮑ Dependencies /app/applications/dependencies
Cases /app/cases
Visualizations /app/visualizations
Add data /app/add-data

Observability project settings list

Label Link Extra
Management /app/management
Integrations /app/integrations
Integrations /app/fleet
Users and roles TBD Links to Cloud console project settings, show external link
Performance TBD Links to Cloud console project settings, show external link
Billing and subscription TBD Links to Cloud console project settings, show external link

TODO

Preview Give feedback

Related tickets:

Links

@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 27, 2023
@sorenlouv sorenlouv added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Mar 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 27, 2023
@kpatticha kpatticha self-assigned this May 9, 2023
@kpatticha
Copy link
Contributor

Latest example of adding side nav for security #156465

@kpatticha
Copy link
Contributor

Has it been decided to keep /app/observability/overview as the default route for opening serverless observability, or is there a plan to change it ?

If the overview nav item is not included in the designs, which route is intended to be set as the default?

cc @chrisdistasio @gbamparop @isaclfreire

@chrisdistasio
Copy link

adding @formgeist

i do not believe that the current o11y overview will be the default route, but it's not yet determined what the route will be.

@formgeist can you confirm?

@formgeist
Copy link
Contributor

@kpatticha /overview won't be part of Serverless. I think we will have Discover be the default route, but that's presented as "Logs" in the designs above. The name will change to Discover in the updated navigation structure. Once I have the updated designs, I'll make sure to add them to this description. The links are not changing, but the labelling and layout will be changed.

@gbamparop
Copy link
Contributor

@formgeist I thought that this would be the landing page for Observability #154928 cc @drewpost

@chrisdistasio
Copy link

@gbamparop i think maybe that would only be the page if there is no data?

@formgeist
Copy link
Contributor

@gbamparop yeah, as @chrisdistasio said the Logs onboarding is the first page users will land on once they've created a Serverless project and there's no data. The general homepage / landingpage (not sure which term we should use here) is that Discover is the new Observability homepage instead of the overview page we have in the current product. When users click "Observability" in the breadcrumbs, it should direct them to Discover.

Discover will still need to show the Logs onboarding if users choose to skip it upon first visit, but we have an overall issue to figure out empty states for this https://github.com/elastic/logs-dev/issues/41

@gbamparop gbamparop added the apm:release-feature APM UI - Release Feature Goal label May 12, 2023
kpatticha added a commit that referenced this issue May 12, 2023
…7360)

## Summary

The PR introduces the first iteration of the side navigation bar for
serverless observability. Part of
#153777

### Run locally

```
yarn serverless-oblt
```

#### Screenshots 


![image](https://github.com/elastic/kibana/assets/3369346/b4a8a4d8-f18e-41e8-bf0e-798a75848885)



https://github.com/elastic/kibana/assets/3369346/39ded143-0d4b-4ea6-9534-0ca87b80662d




### Fixes
- Fix rendering the icon for the nested navigation items  
-
24ee4dc

### Notes

- There is an issue where the selected navigation item is not properly
highlighted and loses focus when the user clicks anywhere else on the
page. (atm out of the scope of the PR)
- The navigation tree is subject to change as there is an ongoing
discussion about the naming and order

---------

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jasonrhodes pushed a commit that referenced this issue May 17, 2023
…7360)

## Summary

The PR introduces the first iteration of the side navigation bar for
serverless observability. Part of
#153777

### Run locally

```
yarn serverless-oblt
```

#### Screenshots 


![image](https://github.com/elastic/kibana/assets/3369346/b4a8a4d8-f18e-41e8-bf0e-798a75848885)



https://github.com/elastic/kibana/assets/3369346/39ded143-0d4b-4ea6-9534-0ca87b80662d




### Fixes
- Fix rendering the icon for the nested navigation items  
-
24ee4dc

### Notes

- There is an issue where the selected navigation item is not properly
highlighted and loses focus when the user clicks anywhere else on the
page. (atm out of the scope of the PR)
- The navigation tree is subject to change as there is an ongoing
discussion about the naming and order

---------

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kpatticha
Copy link
Contributor

@formgeist do you have any updates about the designs?

@kpatticha
Copy link
Contributor

@formgeist
Copy link
Contributor

@formgeist do you have any updates about the designs?

@kpatticha do you mean the updated sidebar navigation or the empty states?

@kpatticha
Copy link
Contributor

@formgeist I was referring to the sidebar navigation

@formgeist
Copy link
Contributor

@kpatticha still work in progress, expect to have the final designs by next week. they're currently in review with the Obs leads looking at the labels and structure.

@kpatticha
Copy link
Contributor

@formgeist thanks 🙏

@formgeist
Copy link
Contributor

@kpatticha @gbamparop Things are still in review (through a number of iterations), but I'm hoping to provide you with the final version of the navigation structure next week. We're planning on user-testing them over the next weeks so any insights might change the order or structure, but I think it's worth considering moving ahead with adding the proposed structure and then following up if there are any changes. WDYT?

@gbamparop
Copy link
Contributor

@kpatticha @gbamparop Things are still in review (through a number of iterations), but I'm hoping to provide you with the final version of the navigation structure next week. We're planning on user-testing them over the next weeks so any insights might change the order or structure, but I think it's worth considering moving ahead with adding the proposed structure and then following up if there are any changes. WDYT?

Thanks for the update @formgeist. I think it makes sense to move ahead if it's final at least before user testing. We might consider targeting IC June instead of merging it in for 8.9 if this doesn't make a difference to you or others.

Would you be using Kibana to demo it if we implement the changes or still to through the designs?

@formgeist
Copy link
Contributor

@gbamparop No problem, I'll update this issue with the final version this week once I have sign-off from the Obs leads.

We might consider targeting IC June instead of merging it in for 8.9 if this doesn't make a difference to you or others.

Doesn't matter for us, but I assume this changes when it'll be available even for internal preview if it's not part of the Serverless project type that we can build from Kibana locally now? Or is that different?

Would you be using Kibana to demo it if we implement the changes or still to through the designs?

We will be using design prototypes for the user testing, so no rush getting this done in code.

@gbamparop
Copy link
Contributor

I assume this changes when it'll be available even for internal preview if it's not part of the Serverless project type that we can build from Kibana locally now? Or is that different?

Serverless work is tracked with ICs anyways so I think this will be aligned.

@sebelga
Copy link
Contributor

sebelga commented Jun 13, 2023

For the visibility to the team I cross link my comment here.
Once the PR is merged all (internal) navigation links will have to use deeplink ids. If the deeplink is marked as hidden by the app it won't render in the navigation tree UI.

If an app is not mounted, its deeplinks won't be registered so even if the Observability navigation definition declares it, it won't render. Let me know if there are any question on that behaviour 👍

@kpatticha
Copy link
Contributor

On serverless the links are hidden until we set navLinkStatus. Related ticket
#159681

@formgeist
Copy link
Contributor

@kpatticha @gbamparop I've updated the description to include the latest navigation structure design along with a list of the navigation items and their proposed route names. Let me know if you have any questions

@gbamparop
Copy link
Contributor

gbamparop commented Jun 23, 2023

The ML requirements are being discussed in this doc (internal). This PR will integrate ML in serverless, let's reach out to the @elastic/ml-ui in case we need help with the links.

@jgowdyelastic
Copy link
Member

jgowdyelastic commented Jun 23, 2023

In reference to the ML PR mentioned above, one of the changes it contains is to update how the ML plugin registers its deeplinks.
As @sebelga mentioned above, we will only register links to features which are available in the project, this allows us to filter nav menu for available ML features with no extra logic.
In my PR I've updated the observability and search nav menus to add a Machine Learning section, this is just the default ML nav menu, with all non-available features automatically hidden.
I'm expecting these ML nav menus to be changed by each plugin, I just thought it'd be good to include an initial example in my PR.

How it currently looks in observability in my PR.

image

kpatticha added a commit that referenced this issue Jun 28, 2023
fixes: #159681
fixes: #153777


<img width="1470" alt="image"
src="https://github.com/elastic/kibana/assets/3369346/eb810c65-c780-4597-9570-4b30cf2e1b09">


### Related
ML deep links won't show until it's merged
#159433

### Test
- e2e will be covered #160674
@kpatticha kpatticha removed the blocked label Jun 29, 2023
@kpatticha kpatticha reopened this Jun 29, 2023
@kpatticha
Copy link
Contributor

reopening to adjust the tree according to the mockups linked today

@kpatticha
Copy link
Contributor

I'm closing the issue as I added test coverage for #160674

The only missing links are

Label Link Extra
Users and roles TBD Links to Cloud console project settings, show external link
Performance TBD Links to Cloud console project settings, show external link
Billing and subscription TBD Links to Cloud console project settings, show external link

They will be added by the shared ux #160942

@gbamparop gbamparop added apm:release-feature APM UI - Release Feature Goal and removed apm:release-feature APM UI - Release Feature Goal apm:test-plan-8.10.0 labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants