-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Serverless navigation #153777
Comments
Pinging @elastic/apm-ui (Team:APM) |
Latest example of adding side nav for security #156465 |
Has it been decided to keep If the overview nav item is not included in the designs, which route is intended to be set as the default? |
adding @formgeist i do not believe that the current o11y overview will be the default route, but it's not yet determined what the route will be. @formgeist can you confirm? |
@kpatticha |
@formgeist I thought that this would be the landing page for Observability #154928 cc @drewpost |
@gbamparop i think maybe that would only be the page if there is no data? |
@gbamparop yeah, as @chrisdistasio said the Logs onboarding is the first page users will land on once they've created a Serverless project and there's no data. The general homepage / landingpage (not sure which term we should use here) is that Discover is the new Observability homepage instead of the overview page we have in the current product. When users click "Observability" in the breadcrumbs, it should direct them to Discover. Discover will still need to show the Logs onboarding if users choose to skip it upon first visit, but we have an overall issue to figure out empty states for this https://github.com/elastic/logs-dev/issues/41 |
…7360) ## Summary The PR introduces the first iteration of the side navigation bar for serverless observability. Part of #153777 ### Run locally ``` yarn serverless-oblt ``` #### Screenshots  https://github.com/elastic/kibana/assets/3369346/39ded143-0d4b-4ea6-9534-0ca87b80662d ### Fixes - Fix rendering the icon for the nested navigation items - 24ee4dc ### Notes - There is an issue where the selected navigation item is not properly highlighted and loses focus when the user clicks anywhere else on the page. (atm out of the scope of the PR) - The navigation tree is subject to change as there is an ongoing discussion about the naming and order --------- Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…7360) ## Summary The PR introduces the first iteration of the side navigation bar for serverless observability. Part of #153777 ### Run locally ``` yarn serverless-oblt ``` #### Screenshots  https://github.com/elastic/kibana/assets/3369346/39ded143-0d4b-4ea6-9534-0ca87b80662d ### Fixes - Fix rendering the icon for the nested navigation items - 24ee4dc ### Notes - There is an issue where the selected navigation item is not properly highlighted and loses focus when the user clicks anywhere else on the page. (atm out of the scope of the PR) - The navigation tree is subject to change as there is an ongoing discussion about the naming and order --------- Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@formgeist do you have any updates about the designs? |
Related tickets:
|
@kpatticha do you mean the updated sidebar navigation or the empty states? |
@formgeist I was referring to the sidebar navigation |
@kpatticha still work in progress, expect to have the final designs by next week. they're currently in review with the Obs leads looking at the labels and structure. |
@formgeist thanks 🙏 |
@kpatticha @gbamparop Things are still in review (through a number of iterations), but I'm hoping to provide you with the final version of the navigation structure next week. We're planning on user-testing them over the next weeks so any insights might change the order or structure, but I think it's worth considering moving ahead with adding the proposed structure and then following up if there are any changes. WDYT? |
Thanks for the update @formgeist. I think it makes sense to move ahead if it's final at least before user testing. We might consider targeting IC June instead of merging it in for 8.9 if this doesn't make a difference to you or others. Would you be using Kibana to demo it if we implement the changes or still to through the designs? |
@gbamparop No problem, I'll update this issue with the final version this week once I have sign-off from the Obs leads.
Doesn't matter for us, but I assume this changes when it'll be available even for internal preview if it's not part of the Serverless project type that we can build from Kibana locally now? Or is that different?
We will be using design prototypes for the user testing, so no rush getting this done in code. |
Serverless work is tracked with ICs anyways so I think this will be aligned. |
For the visibility to the team I cross link my comment here. If an app is not mounted, its deeplinks won't be registered so even if the Observability navigation definition declares it, it won't render. Let me know if there are any question on that behaviour 👍 |
On serverless the links are hidden until we set navLinkStatus. Related ticket |
@kpatticha @gbamparop I've updated the description to include the latest navigation structure design along with a list of the navigation items and their proposed route names. Let me know if you have any questions |
In reference to the ML PR mentioned above, one of the changes it contains is to update how the ML plugin registers its deeplinks. How it currently looks in observability in my PR. ![]() |
fixes: #159681 fixes: #153777 <img width="1470" alt="image" src="https://github.com/elastic/kibana/assets/3369346/eb810c65-c780-4597-9570-4b30cf2e1b09"> ### Related ML deep links won't show until it's merged #159433 ### Test - e2e will be covered #160674
reopening to adjust the tree according to the mockups linked today |
I'm closing the issue as I added test coverage for #160674 The only missing links are
They will be added by the shared ux #160942 |
On Serverless we want to display a dedicated Observability nav instead of the existing nav.
Links:
Implementation details
The menu should be registered via serverless.oblt.yml.
Existing implementations of serverless nav:
Kibana can be started in serverless mode with:
View more screens
Observability navigation item list
/app/discover
/app/dashboards
/app/alerts
/app/slos
/app/aiops/anomaly-detection
/app/aiops/anomaly-detection
/app/aiops/spike-analysis
/app/aiops/change-point-detection
/app/aiops/job-notifications
/app/applications/services
/app/applications/services
/app/applications/traces
/app/applications/dependencies
/app/cases
/app/visualizations
/app/add-data
Observability project settings list
/app/management
/app/integrations
/app/fleet
TODO
Related tickets:
Links
The text was updated successfully, but these errors were encountered: