Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Add side navigation for serverless observability #157360

Merged
merged 16 commits into from
May 12, 2023

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented May 11, 2023

Summary

The PR introduces the first iteration of the side navigation bar for serverless observability. Part of #153777

Run locally

yarn serverless-oblt

Screenshots

image

Screen.Recording.2023-05-11.at.13.41.02.mov

Fixes

  • Fix rendering the icon for the nested navigation items

Notes

  • There is an issue where the selected navigation item is not properly highlighted and loses focus when the user clicks anywhere else on the page. (atm out of the scope of the PR)
  • The navigation tree is subject to change as there is an ongoing discussion about the naming and order

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpatticha kpatticha requested a review from a team May 11, 2023 11:57
@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels May 11, 2023
@kpatticha kpatticha changed the title [Observability] Side nav [Observability] Add side navigation for serverless observability May 11, 2023
@kpatticha kpatticha added the Project:Serverless Work as part of the Serverless project for its initial release label May 11, 2023
@kpatticha kpatticha marked this pull request as ready for review May 11, 2023 11:58
@kpatticha kpatticha requested review from a team as code owners May 11, 2023 11:58
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested to use the serverless plugin for setting the side nav

@kpatticha kpatticha requested a review from tsullivan May 12, 2023 09:50
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessObservability 4 28 +24

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessObservability 1.5KB 21.1KB +19.5KB
serverlessSearch 23.2KB 23.3KB +66.0B
total +19.6KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpatticha kpatticha merged commit 1f99a04 into elastic:main May 12, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 12, 2023
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
…7360)

## Summary

The PR introduces the first iteration of the side navigation bar for
serverless observability. Part of
#153777

### Run locally

```
yarn serverless-oblt
```

#### Screenshots 


![image](https://github.com/elastic/kibana/assets/3369346/b4a8a4d8-f18e-41e8-bf0e-798a75848885)



https://github.com/elastic/kibana/assets/3369346/39ded143-0d4b-4ea6-9534-0ca87b80662d




### Fixes
- Fix rendering the icon for the nested navigation items  
-
24ee4dc

### Notes

- There is an issue where the selected navigation item is not properly
highlighted and loses focus when the user clicks anywhere else on the
page. (atm out of the scope of the PR)
- The navigation tree is subject to change as there is an ongoing
discussion about the naming and order

---------

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants