-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Add side navigation for serverless observability #157360
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…nto oblt-serverless-links
x-pack/plugins/serverless_observability/public/components/side_navigation/index.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested to use the serverless plugin for setting the side nav
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…7360) ## Summary The PR introduces the first iteration of the side navigation bar for serverless observability. Part of #153777 ### Run locally ``` yarn serverless-oblt ``` #### Screenshots  https://github.com/elastic/kibana/assets/3369346/39ded143-0d4b-4ea6-9534-0ca87b80662d ### Fixes - Fix rendering the icon for the nested navigation items - 24ee4dc ### Notes - There is an issue where the selected navigation item is not properly highlighted and loses focus when the user clicks anywhere else on the page. (atm out of the scope of the PR) - The navigation tree is subject to change as there is an ongoing discussion about the naming and order --------- Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
The PR introduces the first iteration of the side navigation bar for serverless observability. Part of #153777
Run locally
Screenshots
Screen.Recording.2023-05-11.at.13.41.02.mov
Fixes
Notes