Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active navigation node title must be styled correctly #157817

Closed
tsullivan opened this issue May 15, 2023 · 9 comments
Closed

Active navigation node title must be styled correctly #157817

tsullivan opened this issue May 15, 2023 · 9 comments
Assignees
Labels
Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

tsullivan commented May 15, 2023

Depends on #154668

The first deliverable for Shared UX's serverless side navigation component is incorrectly styling the "active" link in the menu of items.

Current look:
Image

The visual design we're referencing is:
Image

@botelastic botelastic bot added the needs-team Issues missing a team label label May 15, 2023
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label May 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 15, 2023
@tsullivan tsullivan added the Project:Serverless Work as part of the Serverless project for its initial release label May 15, 2023
@sebelga sebelga self-assigned this Jun 13, 2023
@sebelga
Copy link
Contributor

sebelga commented Jun 13, 2023

@tsullivan I see 2 tasks here:

  • the navigation now needs to have a dark bacground
  • the active item is now a blue bar on the left of the item.

Is that correct?

@tsullivan
Copy link
Member Author

Hi @cee-chen and @ryankeairns,

I think this task is suitable to be carried out by the EUI team. Can you confirm this is the correct understanding?

@tsullivan
Copy link
Member Author

Related: #160053

@tsullivan
Copy link
Member Author

Is that correct?

@sebelga let's defer to @ryankeairns. I believe the mockups I pasted into this issue are out-of-date

@cee-chen
Copy link
Contributor

I think this task is suitable to be carried out by the EUI team. Can you confirm this is the correct understanding?

Yep, agreed that it makes the most sense to have EUI add this styling on our end.

@sebelga
Copy link
Contributor

sebelga commented Jun 21, 2023

Great. @cee-chen who should we assign this issue? Or should we close it in this repo mentioning one in the eui repo?

@cee-chen
Copy link
Contributor

I assumed this was part of our nav redesign work (elastic/eui#6759) - @tsullivan am I off on this? Is this a separate nav design?

@tsullivan
Copy link
Member Author

@cee-chen You have it right. I will close this in favor of elastic/eui#6759. Thanks for the input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

4 participants