Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translatable strings for navigation node titles #157809

Closed
tsullivan opened this issue May 15, 2023 · 3 comments
Closed

Translatable strings for navigation node titles #157809

tsullivan opened this issue May 15, 2023 · 3 comments
Labels
Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

The label strings for navigation nodes will be user-facing production content. The string declarations need to be wrapped in translation utility.
@botelastic botelastic bot added the needs-team Issues missing a team label label May 15, 2023
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label May 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 15, 2023
@tsullivan tsullivan added the Project:Serverless Work as part of the Serverless project for its initial release label May 15, 2023
@kpatticha kpatticha mentioned this issue May 24, 2023
Closed
@sebelga
Copy link
Contributor

sebelga commented Jun 20, 2023 •
edited
Loading

Hey @tsullivan, if this issue still relevant after moving to deeplinks? I've added i18n to all presets (like here) and navigation def (like here)

@tsullivan
Copy link
Member Author

Thanks Seb. I don't see anywhere else that needs focus. Closing as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tsullivan @sebelga @elasticmachine