Update readonly-ref branch from master #18400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type follows the pattern that we assert in the finalizer that it should have been cleaned up. If the type failed to initialize, we would throw and crash the process even though the underlying failure is already past at that point. I'm not saying we shouldn't crash there, but that's a separate decision and we should then target the correct place.
Currently IDE0018 is reported in some cases where a variable is referenced before being definitely assigned. In these cases, inlining the declaration can cause additional problems, where the variable goes from simply being used before being initialized to not being declared in the current scope at all. This change ensures that IDE0018 is not reported in these cases, as the fix would cause more problems than it would resolve. See #18076
The option pages contain controls like Checkboxes and Radiobuttons that themselves contain TextBlocks. These controls are placed inside a ListView. This nesting prevents the TextBlocks from properly inheriting the Foreground from the ancestor ListViewItems so we have to manually add that binding in order to pick up theme changes.
…ion being created.
…dableInHC Make the Naming Style preview text readable in High Contrast
this doesn't replace or change anything yet, just bunch of Operation types for next step. next step is creating CSharp/VBFactory which return these Operation type and replace callsite that return bound node with this. after that, I will create xml/generator from Operation.xml.Generated.cs which can produce Operation.xml.Generated.cs
Don't convert 'static/shared' member initialization into an object initializer statement.
Make extract-method work in expression-bodied accessors.
…sing Improve doc comment collapsing (for outlining).
Don't perform 'commit cleanup' on regions of code with syntax errors *and* multi-line strings.
Refactor the relationship between the Tagger and Notifier.
Add IOperation test helper to verify operation tree and compilation d…
…ing-else-goes-wrong Clean up some lifetime state management in AbstractLanguageService
* Require .NET 4.6 min runtime in app.config Fixes #17908
…l symbols referenced by the node. (#18263) Ensure MethodToStateMachineRewriter.VisitScope properly rewrites local symbols referenced by the node. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?id=401335.
…date-readonly-ref-branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @VSadov @dotnet/roslyn-compiler