Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Implicit Type refactoring incorrect for assigning ValueTuple.Create into tuple #11095

Closed
jcouv opened this issue May 5, 2016 · 0 comments
Assignees
Labels
Area-IDE Bug Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@jcouv
Copy link
Member

jcouv commented May 5, 2016

See background.

The type is apparent in this case and so this test should pass. Currently the action is not available because IsTypeApparentInDeclaration doesn't think the type is apparent.
I think this may be fixed as a side-effect of the work Aleksey is doing on unifying (tuple) and ValueTuple types.

        [WpfFact, Trait(Traits.Feature, Traits.Features.CodeActionsUseImplicitType), Trait(Traits.Feature, Test.Utilities.Traits.Features.Tuples)]
        public async Task ValueTupleCreate_2()
        {
            await TestAsync(
@"using System; class C { static void M() { [|(int, int)|] s = ValueTuple.Create(1, 1); } }" + trivial2uple,
@"using System; class C { static void M() { var s = ValueTuple.Create(1, 1); } }" + trivial2uple,
options: ImplicitTypeWhereApparent(),
parseOptions: TestOptions.Regular.WithTuplesFeature(),
withScriptOption: true);
        }

File UseImplicitTypeTests.cs

@jcouv jcouv self-assigned this May 5, 2016
@jcouv jcouv assigned balajikris and jcouv and unassigned jcouv and balajikris May 7, 2016
@jaredpar jaredpar added the Bug label May 9, 2016
@VSadov VSadov added this to the 2.0 (Preview 1) milestone Jun 11, 2016
@gafter gafter modified the milestones: 2.0 (Preview 1), 2.0 (RC) Jun 20, 2016
@jaredpar jaredpar modified the milestones: 2.0 (RC), 2.0 (RTM) Jul 18, 2016
@jcouv jcouv modified the milestones: 2.1, 2.0 (RTM) Jan 11, 2017
@jcouv jcouv removed their assignment Jan 21, 2017
@Pilchie Pilchie modified the milestones: 15.1, 15.3 Mar 29, 2017
sharwell added a commit to sharwell/roslyn that referenced this issue Mar 29, 2017
@sharwell sharwell added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

7 participants