Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Implicit Type refactoring should detect type as apparent in declaration for ValueTuple #11154

Closed
jcouv opened this issue May 6, 2016 · 3 comments
Assignees
Labels
Area-IDE Bug Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@jcouv
Copy link
Member

jcouv commented May 6, 2016

See background.

This test broke after the tuple symbol has been updated to unify tuple and ValueTuple.

        [WpfFact, Trait(Traits.Feature, Traits.Features.CodeActionsUseImplicitType)]
        public async Task ValueTupleCreate()
        {
            await TestAsync(
@"using System; class C { static void M() { [|ValueTuple<int, int>|] s = ValueTuple.Create(1, 1); } }" + trivial2uple,
@"using System; class C { static void M() { var s = ValueTuple.Create(1, 1); } }" + trivial2uple,
options: ImplicitTypeWhereApparent(),
parseOptions: TestOptions.Regular.WithTuplesFeature(),
withScriptOption: true);
        }

File is UseImplicitTypeTests.cs.

FYI for @balajikris

@jcouv jcouv self-assigned this May 6, 2016
@jcouv jcouv changed the title Use Implicit Type refactoring to detect if type is apparent in declaration for ValueTuple Use Implicit Type refactoring should detect type as apparent in declaration for ValueTuple May 7, 2016
@DustinCampbell
Copy link
Member

Moving to compiler since it's assigned to @jcouv. Let us know if IDE should take a look.

@jaredpar jaredpar added the Bug label May 17, 2016
@VSadov VSadov added this to the 2.0 (Preview 1) milestone Jun 11, 2016
@gafter gafter modified the milestones: 2.0 (Preview 1), 2.0 (RC) Jun 20, 2016
@jaredpar jaredpar modified the milestones: 2.0 (RC), 2.0 (RTM) Jul 18, 2016
@jcouv jcouv modified the milestones: 2.1, 2.0 (RTM) Jan 11, 2017
@jcouv
Copy link
Member Author

jcouv commented Feb 19, 2017

@DustinCampbell What's your thoughts on priority?
Given that the common scenario will be to use tuple syntax and not ValueTuple, I'm moving this out of 2.1.

@jcouv jcouv removed their assignment Feb 19, 2017
@jcouv jcouv modified the milestones: Unknown, 2.1 Feb 19, 2017
@DustinCampbell
Copy link
Member

That makes sense to me. Adding @Pilchie as FYI.

@sharwell sharwell self-assigned this Mar 29, 2017
@sharwell sharwell modified the milestones: 15.3, Unknown Mar 29, 2017
sharwell added a commit to sharwell/roslyn that referenced this issue Mar 29, 2017
@sharwell sharwell added the Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented label Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Feature - Tuples Tuples Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

No branches or pull requests

6 participants