Clean up some lifetime state management in AbstractLanguageService #16985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarolf
approved these changes
Feb 7, 2017
Pilchie
approved these changes
Feb 7, 2017
This type follows the pattern that we assert in the finalizer that it should have been cleaned up. If the type failed to initialize, we would throw and crash the process even though the underlying failure is already past at that point. I'm not saying we shouldn't crash there, but that's a separate decision and we should then target the correct place.
0892cb1 to
81d1bc5
Compare
|
@dotnet-bot test vsi please. |
|
@dotnet-bot test vsi please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type follows the pattern that we assert in the finalizer that it
should have been cleaned up. If the type failed to initialize, we would
throw and crash the process even though the underlying failure is
already past at that point. I'm not saying we shouldn't crash there,
but that's a separate decision and we should then target the correct
place.
Review: @dotnet/roslyn-ide