Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/ibc: client protobuf migration #6254

Closed
wants to merge 22 commits into from
Closed

x/ibc: client protobuf migration #6254

wants to merge 22 commits into from

Conversation

fedekunze
Copy link
Collaborator

Description

replaces #5704

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@fedekunze fedekunze mentioned this pull request May 19, 2020
11 tasks
@fedekunze fedekunze added the S:blocked Status: Blocked label May 19, 2020
@fedekunze fedekunze added this to the IBC 1.0 milestone May 19, 2020
@fedekunze fedekunze removed the S:blocked Status: Blocked label May 28, 2020
@fedekunze fedekunze self-assigned this May 28, 2020
@fedekunze fedekunze added the S:blocked Status: Blocked label May 29, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 4, 2020
@cwgoes cwgoes removed the stale label Jul 6, 2020
@cwgoes
Copy link
Contributor

cwgoes commented Jul 6, 2020

@fedekunze Are we still blocked on upstream Tendermint work here?

@fedekunze
Copy link
Collaborator Author

yeah I need to rebase this to @marbar3778 PR #6471

@fedekunze fedekunze changed the base branch from master to marko/tm_update July 21, 2020 12:53
@colin-axner
Copy link
Contributor

I think this branch is too far gone in terms of conflicts, it'd be much faster to just branch off master and copy paste the proto files over. @fedekunze when tm gets updated in master, want to open a fresh branch we can work off of?

@colin-axner
Copy link
Contributor

closing since there is no need for this branch anymore outside of being a reference

@colin-axner colin-axner closed this Aug 6, 2020
@cwgoes cwgoes deleted the ibc-proto branch August 6, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants