Migrate Tendermint client state to proto #6932
Conversation
| @@ -63,7 +63,8 @@ func (ev Evidence) String() string { | |||
|
|
|||
| // Hash implements Evidence interface | |||
| func (ev Evidence) Hash() tmbytes.HexBytes { | |||
| bz := SubModuleCdc.MustMarshalBinaryBare(ev) | |||
| // TODO use submodule cdc | |||
There was a problem hiding this comment.
using SubModuleCdc here was throwing a proto codec error. Given that the direct followup pr will fix this I thought this is fine for now
There was a problem hiding this comment.
Why is this erroring? Because Evidence hasn't transitioned to proto yet?
There was a problem hiding this comment.
That sounds right, I didn't want to spend the time investigating the issue since it wasn't pressing for this pr. I probably need to add the RegisterInterfaces call from x/evidence
| @@ -51,7 +50,7 @@ func (msg *MsgCreateClient) ProtoMessage() {} | |||
|
|
|||
| // NewMsgCreateClient creates a new MsgCreateClient instance | |||
| func NewMsgCreateClient( | |||
There was a problem hiding this comment.
can't migrate msgs until the header is migrated
…osmos-sdk into colin/tm-client-state-migration
…lient-state-migration
Codecov Report
@@ Coverage Diff @@
## master #6932 +/- ##
==========================================
+ Coverage 55.60% 61.04% +5.44%
==========================================
Files 457 378 -79
Lines 27440 24603 -2837
==========================================
- Hits 15257 15018 -239
+ Misses 11083 8419 -2664
- Partials 1100 1166 +66 |
| @@ -63,7 +63,8 @@ func (ev Evidence) String() string { | |||
|
|
|||
| // Hash implements Evidence interface | |||
| func (ev Evidence) Hash() tmbytes.HexBytes { | |||
| bz := SubModuleCdc.MustMarshalBinaryBare(ev) | |||
| // TODO use submodule cdc | |||
There was a problem hiding this comment.
Why is this erroring? Because Evidence hasn't transitioned to proto yet?
|
|
||
| // RegisterInterfaces registers the tendermint concrete evidence and client-related | ||
| // implementations and interfaces. | ||
| func RegisterInterfaces(registry cdctypes.InterfaceRegistry) { |
There was a problem hiding this comment.
Does this function get called anywhere yet?
There was a problem hiding this comment.
I think I forgot to add the call to x/ibc/types/codec.go which calls it from the module manager callback. Nevertheless this just needs to be added in the followup pr anyways
Description
First step in 02-client migration. Migrates tendermint client state to proto, but leaves 02-client keeper using amino for the codec. This will be done in a followup pr to keep a single pr from becoming too large.
uses lots of work from #6254 (thanks @fedekunze !)
copy/pasted diffs from #6926 because I didn't want to wait for merge to start work
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes