-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate 02-client to use proto encoded/decoded client states #6948
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6948 +/- ##
==========================================
+ Coverage 61.78% 61.80% +0.01%
==========================================
Files 520 521 +1
Lines 32147 32163 +16
==========================================
+ Hits 19861 19877 +16
+ Misses 10676 10672 -4
- Partials 1610 1614 +4 |
@@ -27,17 +28,10 @@ func RegisterInterfaces(registry cdctypes.InterfaceRegistry) { | |||
} | |||
|
|||
var ( | |||
amino = codec.New() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this because 09-localhost does not internal amino encoding, just registration is needed to decode/encode client states at genesis and exporting genesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@fedekunze |
we identified the fix, non-empty genesis states weren't being tested in regular tests. I forgot to update the genesis client states to be pointers. Will post a fix with tests (probably won't get it done until tomorrow |
Description
Followup to #6932
Migrates client states to use
codec.BinaryMarshaler
in02-client
.ClientState
will now be passed around as a pointer. We need to maintain the amino codec registration until the flip is switched on amino encoding genesis, which will occur once IBC genesis is migrated (after consensus states migration).Consensus state migration should be able to occur after we change the validator set to be a hash in the tendermint client: #6942. I'll probably do this change in 2 steps like client state, migrate tendermint consensus state, then flip the switch in 02-client
ref: #6254
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes