Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove consensus state from verifyXYZ funcs #6281

Closed
4 tasks
colin-axner opened this issue May 26, 2020 · 0 comments · Fixed by #7005
Closed
4 tasks

Remove consensus state from verifyXYZ funcs #6281

colin-axner opened this issue May 26, 2020 · 0 comments · Fixed by #7005
Assignees

Comments

@colin-axner
Copy link
Contributor

colin-axner commented May 26, 2020

Summary

Consensus State should be retrieved by the client not the connection keeper. VerifyConsensusState should remain unchanged.

Problem Definition

The consensus state is being added to all verify functions which is varies from the ics spec. This is because the tendermint client needs access to its consensus state.

The retrieval of consensus state by the client was previously blocked by #5502 which has been closed. Since the prefixed store is already being passed into the verify functions, the consensus state can be retrieved from there.

Proposal

Add a GetConsensusState(store sdk.KVStore, height uint64) ConsensusState for the tm client in a types/store.go file.

This is blocked on proto integration to the client keeper. Implementing this currently would require passing an amino codec to the verify funcs. If we wait for proto integration than this will be unnecessary. ref: #6254

Edit: updated issue with better reasoning


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner colin-axner self-assigned this May 27, 2020
@colin-axner colin-axner added the S:blocked Status: Blocked label May 27, 2020
@colin-axner colin-axner changed the title Retrieve consensus state from store within VerifyXYZ Remove consensus state from verifyXYZ funcs May 27, 2020
@colin-axner colin-axner added this to the IBC 1.0 milestone Jul 3, 2020
@colin-axner colin-axner removed the S:blocked Status: Blocked label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant