You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consensus State should be retrieved by the client not the connection keeper. VerifyConsensusState should remain unchanged.
Problem Definition
The consensus state is being added to all verify functions which is varies from the ics spec. This is because the tendermint client needs access to its consensus state.
The retrieval of consensus state by the client was previously blocked by#5502 which has been closed. Since the prefixed store is already being passed into the verify functions, the consensus state can be retrieved from there.
Proposal
Add a GetConsensusState(store sdk.KVStore, height uint64) ConsensusState for the tm client in a types/store.go file.
This is blocked on proto integration to the client keeper. Implementing this currently would require passing an amino codec to the verify funcs. If we wait for proto integration than this will be unnecessary. ref: #6254
Edit: updated issue with better reasoning
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
Consensus State should be retrieved by the client not the connection keeper.
VerifyConsensusState
should remain unchanged.Problem Definition
The consensus state is being added to all verify functions which is varies from the ics spec. This is because the tendermint client needs access to its consensus state.
The retrieval of consensus state by the client was previously blocked by #5502 which has been closed. Since the prefixed store is already being passed into the verify functions, the consensus state can be retrieved from there.
Proposal
Add a
GetConsensusState(store sdk.KVStore, height uint64) ConsensusState
for the tm client in atypes/store.go
file.This is blocked on proto integration to the client keeper. Implementing this currently would require passing an amino codec to the verify funcs. If we wait for proto integration than this will be unnecessary. ref: #6254
Edit: updated issue with better reasoning
For Admin Use
The text was updated successfully, but these errors were encountered: