ConsensusState is retrieved by light clients in verifyXYZ as necessary #7005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7005 +/- ##
==========================================
+ Coverage 61.90% 62.10% +0.20%
==========================================
Files 520 521 +1
Lines 32151 32123 -28
==========================================
+ Hits 19902 19949 +47
+ Misses 10632 10540 -92
- Partials 1617 1634 +17 |
…-remove-constate-from-verifyxyz
alexanderbez
approved these changes
Aug 11, 2020
fedekunze
reviewed
Aug 11, 2020
| @@ -144,6 +144,15 @@ func (cs ClientState) VerifyClientConsensusState( | |||
| return err | |||
| } | |||
|
|
|||
| if consensusState == nil { | |||
There was a problem hiding this comment.
isn't this checked on sanitizeVerificationArgs?
There was a problem hiding this comment.
I took it out of sanitizeVerificationArgs since the consensusState is now being retrieved and decoded from the store
AdityaSripal
previously requested changes
Aug 11, 2020
| ) error { | ||
| merkleProof, err := sanitizeVerificationArgs(cdc, cs, height, prefix, proof, consensusState) | ||
| merkleProof, consensusState, err := sanitizeVerificationArgs(store, cdc, cs, height, prefix, proof) |
There was a problem hiding this comment.
Maybe sanitizeVerificationArgs is a misnomer given its returning the consensus state as well.
Maybe produceVerificationArgs
cwgoes
approved these changes
Aug 12, 2020
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com>
…-remove-constate-from-verifyxyz
…m:cosmos/cosmos-sdk into colin/6281-remove-constate-from-verifyxyz
colin-axner
commented
Aug 12, 2020
fedekunze
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves retrieval of consensus state to verifyXYZ functions. Refactored most of the tests in tm's
client_state_test.goto use ibc testing packagecloses: #6281
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes