Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callouts to serve text messages in regions #2458

Merged
merged 5 commits into from
Jan 21, 2020

Conversation

nategraf
Copy link
Contributor

Description

Add callouts to serve text messages in regions to address confusion.

@nategraf nategraf requested a review from nambrot January 16, 2020 20:32
@nategraf nategraf added the automerge Have PR merge automatically when checks pass label Jan 16, 2020
@nategraf nategraf changed the base branch from master to baklava January 16, 2020 20:33
@nategraf nategraf changed the base branch from baklava to master January 16, 2020 20:33
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #2458 into master will increase coverage by 0.25%.
The diff coverage is 81.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2458      +/-   ##
==========================================
+ Coverage   74.53%   74.79%   +0.25%     
==========================================
  Files         280      281       +1     
  Lines        7920     7922       +2     
  Branches     1015     1013       -2     
==========================================
+ Hits         5903     5925      +22     
+ Misses       1903     1894       -9     
+ Partials      114      103      -11
Flag Coverage Δ
#mobile 74.79% <81.02%> (+0.25%) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/images/exchangeGreenGold.png 100% <ø> (ø)
packages/mobile/src/localCurrency/convert.ts 87.5% <ø> (ø) ⬆️
packages/mobile/src/images/exchangeGoldGreen.png 100% <ø> (ø)
packages/mobile/src/localCurrency/actions.ts 100% <ø> (ø) ⬆️
packages/mobile/src/localCurrency/reducer.ts 50% <ø> (ø) ⬆️
packages/mobile/src/transactions/reducer.ts 47.36% <0%> (-22.91%) ⬇️
packages/mobile/src/localCurrency/saga.ts 73.07% <0%> (+5.21%) ⬆️
packages/mobile/src/account/InviteReview.tsx 88.88% <100%> (ø) ⬆️
packages/mobile/src/images/Images.ts 100% <100%> (ø) ⬆️
packages/mobile/src/home/WalletHome.tsx 90.24% <100%> (+0.12%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e1a44...f98ef18. Read the comment docs.

@celo-ci-bot-user celo-ci-bot-user merged commit 3962404 into master Jan 21, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the victor/twilio-regions branch January 21, 2020 18:32
aaronmgdr added a commit that referenced this pull request Jan 21, 2020
* master: (25 commits)
  Add react-testing-utils + Fix Analytics (#2437)
  collect coverage on web (#2415)
  Add callouts to serve text messages in regions (#2458)
  [Wallet] Historical currency conversions in the transaction feed (#2446)
  CLI relock fix (#2464)
  Update copyright year + inline button  (#2468)
  Voting bot for stake off (#2327)
  Change order of profile info (#2454)
  [Wallet] Fix type check regression for components wrapped by our custom `withTranslation` (#2457)
  Unfreeze rewards by default (#2452)
  Baklava and baklavastaging deploys (#2421)
  Fix coin colors  (#2441)
  Make governance CLI more usable (#2428)
  Slashing params for stake off phase 2 (#2418)
  [Wallet] Rollback zeroSync toggle in case it was not successful (#2434)
  [Wallet] Cleanup unused StateProps references (#2439)
  Add unit tests and cli checks for validator hotfix interaction (#2340)
  Add proper Spanish translations (#2427)
  Catch exceptions during polling (#2432)
  Add unfreeze-contracts command to celotool (#2433)
  ...

# Conflicts:
#	packages/web/src/brandkit/common/MobileMenu.test.tsx
#	yarn.lock
aaronmgdr added a commit that referenced this pull request Jan 21, 2020
* master:
  Add react-testing-utils + Fix Analytics (#2437)
  collect coverage on web (#2415)
  Add callouts to serve text messages in regions (#2458)
  [Wallet] Historical currency conversions in the transaction feed (#2446)
  CLI relock fix (#2464)
  Update copyright year + inline button  (#2468)
  Voting bot for stake off (#2327)
  Change order of profile info (#2454)
  [Wallet] Fix type check regression for components wrapped by our custom `withTranslation` (#2457)
  Unfreeze rewards by default (#2452)

# Conflicts:
#	packages/web/src/analytics/analytics.test.ts
#	packages/web/src/brandkit/common/MobileMenu.test.tsx
#	yarn.lock
aaronmgdr added a commit that referenced this pull request Jan 22, 2020
* master:
  add celo.org/about#contributors id (#2488)
  [Wallet] Fix integration build firebase db url on Android (#2495)
  Fixes governance CLI bugs encountered while running election contract upgrade (#2482)
  Add validator:signed-blocks command and fix validator:status bug (#2456)
  Bump @celo/celocli version to 0.0.34 (#2420)
  Fix Logo + backers number change (#2453)
  Improve election efficiency by short circuiting (#2475)
  Page for Experience / BrandKit / Composition (#2462)
  Configure the time to wait for text messages (#2450)
  Add react-testing-utils + Fix Analytics (#2437)
  collect coverage on web (#2415)
  Add callouts to serve text messages in regions (#2458)
  [Wallet] Historical currency conversions in the transaction feed (#2446)
  CLI relock fix (#2464)
  Update copyright year + inline button  (#2468)
  Voting bot for stake off (#2327)
aaronmgdr added a commit that referenced this pull request Jan 23, 2020
* master: (72 commits)
  [Wallet] Fix incorrect empty state on the gold tab (#2510)
  Added ingress resource for celostats DNS (#2480)
  Fix celotool testnet deploy (#2501)
  [Wallet] Navigate to wallet home after payment request (#2500)
  Require Consent for tracking globally (#2489)
  new academic papers + minor fix to web events (#2502)
  [Wallet] Fetch tobin tax for exchanges (#1492)
  add celo.org/about#contributors id (#2488)
  [Wallet] Fix integration build firebase db url on Android (#2495)
  Fixes governance CLI bugs encountered while running election contract upgrade (#2482)
  Add validator:signed-blocks command and fix validator:status bug (#2456)
  Bump @celo/celocli version to 0.0.34 (#2420)
  Fix Logo + backers number change (#2453)
  Improve election efficiency by short circuiting (#2475)
  Page for Experience / BrandKit / Composition (#2462)
  Configure the time to wait for text messages (#2450)
  Add react-testing-utils + Fix Analytics (#2437)
  collect coverage on web (#2415)
  Add callouts to serve text messages in regions (#2458)
  [Wallet] Historical currency conversions in the transaction feed (#2446)
  ...

# Conflicts:
#	.circleci/config.yml
#	packages/web/src/brandkit/common/Page.tsx
#	packages/web/src/logos/LogoLightBg.tsx
#	packages/web/static/locales/en/brand.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants