Fixes governance CLI bugs encountered while running election contract upgrade #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2482 +/- ##
=======================================
Coverage 73.6% 73.6%
=======================================
Files 554 554
Lines 13667 13667
Branches 1352 1641 +289
=======================================
Hits 10059 10059
Misses 3330 3330
Partials 278 278
Continue to review full report at Codecov.
|
nambrot
approved these changes
Jan 21, 2020
aaronmgdr
added a commit
that referenced
this pull request
Jan 22, 2020
* master: Fixes governance CLI bugs encountered while running election contract upgrade (#2482) Add validator:signed-blocks command and fix validator:status bug (#2456) Bump @celo/celocli version to 0.0.34 (#2420) Fix Logo + backers number change (#2453) Improve election efficiency by short circuiting (#2475) Page for Experience / BrandKit / Composition (#2462) Configure the time to wait for text messages (#2450) # Conflicts: # packages/web/package.json
aaronmgdr
added a commit
that referenced
this pull request
Jan 22, 2020
* master: add celo.org/about#contributors id (#2488) [Wallet] Fix integration build firebase db url on Android (#2495) Fixes governance CLI bugs encountered while running election contract upgrade (#2482) Add validator:signed-blocks command and fix validator:status bug (#2456) Bump @celo/celocli version to 0.0.34 (#2420) Fix Logo + backers number change (#2453) Improve election efficiency by short circuiting (#2475) Page for Experience / BrandKit / Composition (#2462) Configure the time to wait for text messages (#2450) Add react-testing-utils + Fix Analytics (#2437) collect coverage on web (#2415) Add callouts to serve text messages in regions (#2458) [Wallet] Historical currency conversions in the transaction feed (#2446) CLI relock fix (#2464) Update copyright year + inline button (#2468) Voting bot for stake off (#2327)
aaronmgdr
added a commit
that referenced
this pull request
Jan 23, 2020
* master: (72 commits) [Wallet] Fix incorrect empty state on the gold tab (#2510) Added ingress resource for celostats DNS (#2480) Fix celotool testnet deploy (#2501) [Wallet] Navigate to wallet home after payment request (#2500) Require Consent for tracking globally (#2489) new academic papers + minor fix to web events (#2502) [Wallet] Fetch tobin tax for exchanges (#1492) add celo.org/about#contributors id (#2488) [Wallet] Fix integration build firebase db url on Android (#2495) Fixes governance CLI bugs encountered while running election contract upgrade (#2482) Add validator:signed-blocks command and fix validator:status bug (#2456) Bump @celo/celocli version to 0.0.34 (#2420) Fix Logo + backers number change (#2453) Improve election efficiency by short circuiting (#2475) Page for Experience / BrandKit / Composition (#2462) Configure the time to wait for text messages (#2450) Add react-testing-utils + Fix Analytics (#2437) collect coverage on web (#2415) Add callouts to serve text messages in regions (#2458) [Wallet] Historical currency conversions in the transaction feed (#2446) ... # Conflicts: # .circleci/config.yml # packages/web/src/brandkit/common/Page.tsx # packages/web/src/logos/LogoLightBg.tsx # packages/web/static/locales/en/brand.json
This was referenced Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusts behavior of governance cli commands to be less cumbersome
Tested
Against
yarn test:livechainOther changes
Adds util for trimming web3 abi decoded parameters of index-labelled keys
Related issues