Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unfreeze-contracts command to celotool #2433

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Conversation

nategraf
Copy link
Contributor

Description

Add an unfreeze-contracts command to celotool to unfreeze (or freeze) the Exchange and EpochRewards contracts on demand.

Tested

Manually against a local testnet and baklavastaging

description: 'Freeze contracts instead of unfreezing',
default: false,
})
.option('precheck', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we always do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want this to be an option in case it causes some kind of issue.

description: 'Check the contract freeze status before continuing',
default: true,
})
.option('verify', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, shouldn't we always do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want this to be an option in case it causes some kind of issue.

@nategraf nategraf added the automerge Have PR merge automatically when checks pass label Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #2433 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2433    +/-   ##
========================================
  Coverage   74.58%   74.58%            
========================================
  Files         280      280            
  Lines        7912     7912            
  Branches     1016      732   -284     
========================================
  Hits         5901     5901            
  Misses       1897     1897            
  Partials      114      114
Flag Coverage Δ
#mobile 74.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310c40e...c5f81ce. Read the comment docs.

@celo-ci-bot-user celo-ci-bot-user merged commit 2ff1c70 into master Jan 14, 2020
@celo-ci-bot-user celo-ci-bot-user deleted the victor/defrost branch January 14, 2020 05:38
aaronmgdr added a commit that referenced this pull request Jan 15, 2020
* master: (30 commits)
  Fix coin colors  (#2441)
  Make governance CLI more usable (#2428)
  Slashing params for stake off phase 2 (#2418)
  [Wallet] Rollback zeroSync toggle in case it was not successful (#2434)
  [Wallet] Cleanup unused StateProps references (#2439)
  Add unit tests and cli checks for validator hotfix interaction (#2340)
  Add proper Spanish translations (#2427)
  Catch exceptions during polling (#2432)
  Add unfreeze-contracts command to celotool (#2433)
  Fix verify-contracts file dependency missing (#2426)
  Upload correct bootnode IP address on internal testnet (#2402)
  [Wallet]: Historic Gold prices chart (#2345)
  Fix documentation link (#2404)
  Docs nits (#2424)
  Update genesis block accounts config to be correct for phase 2 (#2416)
  Sort on correct vote amount in validator election migration (#2417)
  Make attestation opt-in (#2230)
  Adjustment to home banner / mobile menu (#2408)
  Clarify documentation on validator proxy (#2371)
  [Slashing] Adding whitelist checks for onlySlasher to Validators.sol (#2347)
  ...
aaronmgdr added a commit that referenced this pull request Jan 21, 2020
* master: (25 commits)
  Add react-testing-utils + Fix Analytics (#2437)
  collect coverage on web (#2415)
  Add callouts to serve text messages in regions (#2458)
  [Wallet] Historical currency conversions in the transaction feed (#2446)
  CLI relock fix (#2464)
  Update copyright year + inline button  (#2468)
  Voting bot for stake off (#2327)
  Change order of profile info (#2454)
  [Wallet] Fix type check regression for components wrapped by our custom `withTranslation` (#2457)
  Unfreeze rewards by default (#2452)
  Baklava and baklavastaging deploys (#2421)
  Fix coin colors  (#2441)
  Make governance CLI more usable (#2428)
  Slashing params for stake off phase 2 (#2418)
  [Wallet] Rollback zeroSync toggle in case it was not successful (#2434)
  [Wallet] Cleanup unused StateProps references (#2439)
  Add unit tests and cli checks for validator hotfix interaction (#2340)
  Add proper Spanish translations (#2427)
  Catch exceptions during polling (#2432)
  Add unfreeze-contracts command to celotool (#2433)
  ...

# Conflicts:
#	packages/web/src/brandkit/common/MobileMenu.test.tsx
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants