Catch exceptions during polling #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2432 +/- ##
========================================
Coverage 74.58% 74.58%
========================================
Files 280 280
Lines 7912 7912
Branches 732 1016 +284
========================================
Hits 5901 5901
Misses 1897 1897
Partials 114 114
Continue to review full report at Codecov.
|
timmoreton
approved these changes
Jan 14, 2020
aaronmgdr
added a commit
that referenced
this pull request
Jan 15, 2020
* master: (30 commits) Fix coin colors (#2441) Make governance CLI more usable (#2428) Slashing params for stake off phase 2 (#2418) [Wallet] Rollback zeroSync toggle in case it was not successful (#2434) [Wallet] Cleanup unused StateProps references (#2439) Add unit tests and cli checks for validator hotfix interaction (#2340) Add proper Spanish translations (#2427) Catch exceptions during polling (#2432) Add unfreeze-contracts command to celotool (#2433) Fix verify-contracts file dependency missing (#2426) Upload correct bootnode IP address on internal testnet (#2402) [Wallet]: Historic Gold prices chart (#2345) Fix documentation link (#2404) Docs nits (#2424) Update genesis block accounts config to be correct for phase 2 (#2416) Sort on correct vote amount in validator election migration (#2417) Make attestation opt-in (#2230) Adjustment to home banner / mobile menu (#2408) Clarify documentation on validator proxy (#2371) [Slashing] Adding whitelist checks for onlySlasher to Validators.sol (#2347) ...
aaronmgdr
added a commit
that referenced
this pull request
Jan 21, 2020
* master: (25 commits) Add react-testing-utils + Fix Analytics (#2437) collect coverage on web (#2415) Add callouts to serve text messages in regions (#2458) [Wallet] Historical currency conversions in the transaction feed (#2446) CLI relock fix (#2464) Update copyright year + inline button (#2468) Voting bot for stake off (#2327) Change order of profile info (#2454) [Wallet] Fix type check regression for components wrapped by our custom `withTranslation` (#2457) Unfreeze rewards by default (#2452) Baklava and baklavastaging deploys (#2421) Fix coin colors (#2441) Make governance CLI more usable (#2428) Slashing params for stake off phase 2 (#2418) [Wallet] Rollback zeroSync toggle in case it was not successful (#2434) [Wallet] Cleanup unused StateProps references (#2439) Add unit tests and cli checks for validator hotfix interaction (#2340) Add proper Spanish translations (#2427) Catch exceptions during polling (#2432) Add unfreeze-contracts command to celotool (#2433) ... # Conflicts: # packages/web/src/brandkit/common/MobileMenu.test.tsx # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When TME polls for whether it is still actively connected, exceptions during the poll are effectively ignored and possibly let TME hang perpetually without exiting 1. This PR catches those exceptions and assumes negatively.
Tested