Add vertical tabs P3A metrics #18834

DJAndries · 2023-06-09T00:08:21Z

Resolves brave/brave-browser#30928

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

For open tabs metric:

Start with fresh profile. Ensure metric does not exist in local state.
Enable vertical tabs, reload local state, ensure metric has value of 0.
Open multiple tabs, ensure metric value changes as expected.
Open multiple tabs in another window, ensure metric value changes as expected.
Close most of the tabs in both windows, ensure metric value is the same.
Close browser, advance system time by seven days, ensure metric has value of 0.

For group tabs metric:

Start with fresh profile. Ensure metric does not exist in local state.
Enable vertical tabs, reload local state, ensure metric does not exist.
Create a group, quickly switch between tabs (to trigger the underlying tab model callback), ensure metric has value of 0.
Create multiple groups, quickly switch between tabs, ensure metric value changes as expected.
Create multiple groups in another window, quickly switch between tabs, ensure metric value changes as expected.
Close most of the groups in both windows,quickly switch between tabs, ensure metric value is the same.
Close all groups, ensure metric is sent, close browser, advance system time by seven days, ensure metric does not exist.

For pinned tabs metric:

Start with fresh profile. Ensure metric does not exist in local state.
Enable vertical tabs, reload local state, ensure metric does not exist.
Create and pin a tab, quickly switch between tabs (to trigger the underlying tab model callback), ensure metric has value of 0.
Pin multiple tabs, quickly switch between tabs, ensure metric value changes as expected.
Pin multiple tabs in another window, quickly switch between tabs, ensure metric value changes as expected.
Unpin most tabs in both windows, quickly switch between tabs, ensure metric value is the same.
Unpin all tabs, ensure metric is sent, close browser, advance system time by seven days, ensure metric does not exist.

iefremov · 2023-06-16T22:00:46Z

i think we need an author(s) of the vertical tabs feature to review, maybe @sangwoo108 is a proper person?

browser/misc_metrics/process_misc_metrics.cc

browser/misc_metrics/vertical_tab_metrics.h

browser/misc_metrics/vertical_tab_metrics.cc

…encapsulate all misc_metrics classes that the browser process owns

sangwoo108

LGTM with a last question 👍

browser/brave_browser_process_impl.cc

GeetaSarvadnya · 2023-06-27T15:38:34Z

Verification PASSED on

Brave | 1.55.17 Chromium: 115.0.5790.40 (Official Build) nightly (64-bit)
-- | --
Revision | 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS | Windows 10 Version 22H2 (Build 19045.3086)

Logged Follow up of # PR 18834 - Incorrect response for the metrics Brave.VerticalTabs.OpenTabs when tabs are added/closed on the vertical tab view brave-browser#31356
Logged Follow up of # PR 18834 - Incorrect response for the metrics Brave.VerticalTabs.PinnedTabs when tabs are pinned and unpinned brave-browser#31365
Logged Follow up of # PR 18834 - Incorrect response for the metrics Brave.VerticalTabs.GroupTabs when tabs are group and ngroup on the vertical tab view brave-browser#31366
Logged Follow up of # PR 18834 - The tabs opened in PT and TOR windows are not considered for the metrics response calculation brave-browser#31367
Logged Follow up of # PR 18834 - The pinned tabs and tabgroups created in new window are not considered for the metrics response calculation brave-browser#31368

Brave.VerticalTabs.OpenTabs

Case 0: Brave.VerticalTabs.OpenTabs = 0_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that there is only 1 tab is opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 0

Case 1: Brave.VerticalTabs.OpenTabs = 1_PASSED

Case 1.1: no of tabs opened = 2_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 2 tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 1

Case 1.2: no of tabs opened = 5_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 5 tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 1

Case 1.3: no of tabs opened < 5_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 3 tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 1

Case 2: Brave.VerticalTabs.OpenTabs = 2_PASSED

Case 2.1: no of tabs opened = 6_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 6 tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 2 as expected

Case 2.2: no of tabs opened = 10_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 10 tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 2 as expected

Case 2.3: no of tabs opened < 10_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 9 tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 2 as expected

Case 3: Brave.VerticalTabs.OpenTabs = 3_PASSED

Case 3.1: no of tabs opened = 11_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 11 tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 3 as expected

Case 3.2: no of tabs opened = 50_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 50 tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 3 as expected

Case 4: Brave.VerticalTabs.OpenTabs = 4_PASSED

Case 4.1: no of tabs opened = 11_PASSED

Clean profile 1.55.17
Enable vertical tabs via brave://settings/appearance
Open brave://local-state
Make sure that 51+ tabs are opened
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 4 as expected

Brave.VerticalTabs.PinnedTabs

Case 1: Brave.VerticalTabs.PinnedTabs = 0_PASSED

Case 1.1: Brave.VerticalTabs.PinnedTabs = 0_PASSED

Clean profile 1.55.17
Open brave://local-state
Right click on the brave://local-state tab, select Use vertical tabs context menu option
Make sure these is only one tab in the vertical tab view
Pin the tab on the vertical tab view
Reload brave://local-state file
Restart the browser
Look for the metrics Brave.VerticalTabs.PinnedTabs
Confirmed that the metrics Brave.VerticalTabs.PinnedTabs response value is 0 as expected

Case 1.1: Brave.VerticalTabs.PinnedTabs = 0_PASSED

Clean profile 1.55.17
Open brave://local-state
Right click on the brave://local-state tab, select Use vertical tabs context menu option
Pin the tab on the vertical tab view
Open another tab and Pin the tab and make sure there are 2 tabs pinned
Reload brave://local-state file
Restart the browser
Look for the metrics Brave.VerticalTabs.PinnedTabs
Confirmed that the metrics Brave.VerticalTabs.PinnedTabs response value is 0 as expected

Case 2: Brave.VerticalTabs.PinnedTabs = 1_PASSED

Case 2.1: Brave.VerticalTabs.PinnedTabs = 1_PASSED

Clean profile 1.55.17
Open brave://local-state
Right click on the brave://local-state tab, select Use vertical tabs context menu option
Pin the tab on the vertical tab view
Open another 2 tabs and Pin the tabs and make sure there are 3 tabs pinned
Reload brave://local-state file
Restart the browser
Look for the metrics Brave.VerticalTabs.PinnedTabs
Confirmed that the metrics Brave.VerticalTabs.PinnedTabs response value is 1 as expected

Case 2.2: Brave.VerticalTabs.PinnedTabs = 1_PASSED

Clean profile 1.55.17
Open brave://local-state
Right click on the brave://local-state tab, select Use vertical tabs context menu option
Pin the tab on the vertical tab view
Open another 3 tabs and Pin the tabs and make sure there are 4 tabs pinned
Reload brave://local-state file
Restart the browser
Look for the metrics Brave.VerticalTabs.PinnedTabs
Confirmed that the metrics Brave.VerticalTabs.PinnedTabs response value is 1 as expected

Case 2.3: Brave.VerticalTabs.PinnedTabs = 1_PASSED

Clean profile 1.55.17
Open brave://local-state
Right click on the brave://local-state tab, select Use vertical tabs context menu option
Pin the tab on the vertical tab view
Open another 4 tabs and Pin the tabs and make sure there are 5 tabs pinned
Reload brave://local-state file
Restart the browser
Look for the metrics Brave.VerticalTabs.PinnedTabs
Confirmed that the metrics Brave.VerticalTabs.PinnedTabs response value is 1 as expected

Case 3: Brave.VerticalTabs.PinnedTabs = 2_PASSED

Clean profile 1.55.17
Open brave://local-state
Right click on the brave://local-state tab, select Use vertical tabs context menu option
Pin the tab on the vertical tab view
Open another 5 tabs and Pin the tabs and make sure there are 6 tabs pinned
Reload brave://local-state file
Restart the browser
Look for the metrics Brave.VerticalTabs.PinnedTabs
Confirmed that the metrics Brave.VerticalTabs.PinnedTabs response value is 2 as expected

Brave.VerticalTabs.GroupTabs

Case 1: Brave.VerticalTabs.GroupTabs = 0_PASSED

Case 1.1: Brave.VerticalTabs.GroupTabs = 0_PASSED

Clean profile 1.55.17 and enable vertical tabs
Open few tabs with sites opened in tabs
Create a tab group 1
Open brave://local-state file
Look for the metrics Brave.VerticalTabs.GroupTabs
Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 0 as expected

Case 1.2: Brave.VerticalTabs.GroupTabs = 0_PASSED

Clean profile 1.55.17 and enable vertical tabs
Open few tabs with sites opened in tabs
Create two tab groups
Open brave://local-state file
Look for the metrics Brave.VerticalTabs.GroupTabs
Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 0 as expected

Case 2: Brave.VerticalTabs.GroupTabs = 1_PASSED

Case 2.1: Brave.VerticalTabs.GroupTabs = 1_PASSED

Clean profile 1.55.17 and enable vertical tabs
Open few tabs with sites opened in tabs
Create 3 tab groups
Open brave://local-state file
Look for the metrics Brave.VerticalTabs.GroupTabs
Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 1 as expected

Case 2.2: Brave.VerticalTabs.GroupTabs = 1_PASSED

Clean profile 1.55.17 and enable vertical tabs
Open few tabs with sites opened in tabs
Create 4 tab groups
Open brave://local-state file
Look for the metrics Brave.VerticalTabs.GroupTabs
Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 1 as expected

Case 2.3: Brave.VerticalTabs.GroupTabs = 1_PASSED

Clean profile 1.55.17 and enable vertical tabs
Open few tabs with sites opened in tabs
Create 5 tab groups
Open brave://local-state file
Look for the metrics Brave.VerticalTabs.GroupTabs
Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 1 as expected

Brave.VerticalTabs.GroupTabs = 2_PASSED

Clean profile 1.55.17
Open few tabs with sites opened in tabs
Create 6 tab groups
Open brave://local-state file
Look for the metrics Brave.VerticalTabs.GroupTabs
Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 2 as expected

Additional scenarios

Case 1: Tabs added via PT/TOR/Guest_PASSED

Clean profile 1.55.17
Enable vertical tabs view
Add 7 sites in 7 tabs
Confirm that the metrics Brave.VerticalTabs.OpenTabs response value is 2 as expected
Open a PT window and add two tabs with sites loaded
Open a TOR window and add two tabs with sites loaded
Number tabs in all the 3 window types (normal, PT and TOR window) is 11
Reload brave://local-state file
The metrics Brave.VerticalTabs.OpenTabs response value is 2 instead of 3
If we look at the metrics Brave.Core.TabCount it gives the correct reponse when tab count is 7 and 11

Case 2: Move Tabs to new window_PASSED

Case 2.1: Move Tabs to new window_PASSED

Clean profile 1.55.17
Enable vertical tabs view
Add 5 sites in 5 tabs
Confirm that the metrics Brave.VerticalTabs.OpenTabs response value is 1 as expected
Right click on any tab in vertical tav view and select the Move tab to another window context menu
Confirm that the tab is moved to the new window
Add second tab in new window (step 6 window)
Confirm that the total tabs opened in the original window and new window is 6
Reload brave://local-state file
Confirm that the metrics Brave.VerticalTabs.OpenTabs response value is 2 as expected

Case 2.2: Move pinned Tabs to new window_PASSED

Clean profile 1.55.17
Enable vertical tabs view
Add 2 sites in 2 tabs
Pin both the tabs
Confirm that the metrics Brave.VerticalTabs.PinnedTabs response value is 0 as expected
Right click on any pinned tab in vertical tab view and select the Move tab to another window context menu
Confirm that the pinned tab is moved to the new window
Add second tab in new window and pin it (step 6 window)
Confirm that the total tabs pinned in the original window and new window is 3
Reload brave://local-state file
the metrics Brave.VerticalTabs.PinnedTabs response value is 0 instead of 1

Case 2.3: Move Tab group to new window_PASSED

Clean profile 1.55.17
Enable vertical tabs view
Add 2 sites in 2 tabs
Create two tab groups (Group 1 and Group 2)
Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 0 as expected
Right click on any tabgroup in vertical tab view and select the Move tab to another window context menu
Confirm that the tabgroup is moved to the new window
Add second tab in new window and create a 3rd tab gropu (step 6 window)
Confirm that the total tabgroups in the original window and new window is 3
Reload brave://local-state file
the metrics Brave.VerticalTabs.PinnedTabs response value is 0 instead of 1

Case 3: Brave.VerticalTabs.OpenTabs_PASSED

Set sys date to 19th June, clean profile 1.55.17
Open brave://local-state
Enable vertical tabs via brave://settings/appearance
Ensure that there are two tabs on the vertical tab view
Look for the metrics Brave.VerticalTabs.OpenTabs
Confirmed that the metrics Brave.VerticalTabs.OpenTabs response value is 1 as expected
Close one tab and make sure there is only one tab on the vertical tab view
Reload brave://local-state file
Wait for 1 minute and restart the browser
The metrics Brave.VerticalTabs.OpenTabs response value is 1 for the 1st week
Fwd the sys clock ahead by 8 days (i.e 26th June in my case) [If I fwd the sys clock to 25th June the value 1 remains same]
Reload brave://local-state file
The metrics Brave.VerticalTabs.PinnedTabs response value is 0 as expected in the 2nd week

Case 4: Brave.VerticalTabs.PinnedTabs_PASSED

Set sys date to 19th June
Clean profile 1.55.17
Open brave://local-state file, right click on the tab and select Use vertical tabs context menu
Open 5 more tabs and pin all the tabs including brave://local-state file, total pinned tabs count is 6
Reload brave://local-state file
The metrics Brave.VerticalTabs.PinnedTabs response value is 2 as expected
Unpin 3 tabs and reload brave://local-state file and enured metrics response value is still 2 for the 1st week
Fwd the sys clock ahead by 8 days (i.e 26th June in my case) [If I fwd the sys clock to 25th June the value 2 remains same]
Reload brave://local-state file
The metrics Brave.VerticalTabs.PinnedTabs response value is 1 as expected in the 2nd week

Case 5: Brave.VerticalTabs.GroupTabs_PASSED

Set sys date to 19th June
Clean profile 1.55.17
Open brave://local-state file, right click on the tab and select Use vertical tabs context menu
Open a bunch of sites
Create 6 tab groups
Reload the bave://local-state file
Look for the metrics Brave.VerticalTabs.GroupTabs
Confirmed that the metrics Brave.VerticalTabs.GroupTabs response value is 2 as expected
Remove 6th tab group
Reload the bave://local-state file
The metrics Brave.VerticalTabs.GroupTabs response value is 2 in the 1st week
Close the browser
Fwd the sys clock ahead by 8 days (i.e 26th June in my case) [If I fwd the sys clock to 25th June the value 2 remains same]
Reload brave://local-state file
Confirmed that the metrics Brave.VerticalTabs.GroupTabs response value is 1 as expected in the 2nd week

Uplift of #18834 (squashed) to beta

DJAndries requested a review from a team as a code owner June 9, 2023 00:08

github-actions bot assigned DJAndries Jun 9, 2023

DJAndries force-pushed the vertical-tab-p3a branch 5 times, most recently from 297e596 to 84e9f64 Compare June 10, 2023 01:22

DJAndries requested a review from sangwoo108 June 17, 2023 04:18

sangwoo108 reviewed Jun 19, 2023

View reviewed changes

DJAndries force-pushed the vertical-tab-p3a branch from 84e9f64 to 751bfee Compare June 19, 2023 23:18

DJAndries requested a review from sangwoo108 June 19, 2023 23:45

DJAndries added 3 commits June 20, 2023 16:05

Move misc_metrics::MenuMetrics to ProcessMiscMetrics, a new class to …

b8b099b

…encapsulate all misc_metrics classes that the browser process owns

Fix TimePeriodStorage::IsOnePeriodPassed

a4b1737

Add vertical tab P3A metrics

ec53193

DJAndries force-pushed the vertical-tab-p3a branch 2 times, most recently from 998110d to ecccb63 Compare June 21, 2023 05:11

sangwoo108 approved these changes Jun 21, 2023

View reviewed changes

browser/brave_browser_process_impl.cc Show resolved Hide resolved

Vertical tab P3A improvements as per feedback

7c1f503

DJAndries force-pushed the vertical-tab-p3a branch from ecccb63 to 7c1f503 Compare June 21, 2023 19:15

iefremov approved these changes Jun 26, 2023

View reviewed changes

DJAndries merged commit 97f6043 into master Jun 27, 2023

DJAndries deleted the vertical-tab-p3a branch June 27, 2023 01:45

github-actions bot added this to the 1.55.x - Nightly milestone Jun 27, 2023

brave-builds mentioned this pull request Jul 6, 2023

Add vertical tabs P3A metrics (uplift to 1.57.x) #19182

Merged

7 tasks

brave-builds added a commit that referenced this pull request Jul 6, 2023

Uplift of #18834 (squashed) to beta

41bdb12

DJAndries mentioned this pull request Jul 6, 2023

Vertical tabs p3a (uplift to 1.56.x) #19185

Merged

25 tasks

kjozwiak pushed a commit that referenced this pull request Jul 7, 2023

Add vertical tabs P3A metrics (uplift to 1.57.x) (#19182)

fa4d42e

Uplift of #18834 (squashed) to beta

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add vertical tabs P3A metrics #18834

Add vertical tabs P3A metrics #18834

DJAndries commented Jun 9, 2023 •

edited

Loading

iefremov commented Jun 16, 2023

sangwoo108 left a comment

GeetaSarvadnya commented Jun 27, 2023 •

edited

Loading

Add vertical tabs P3A metrics #18834

Add vertical tabs P3A metrics #18834

Conversation

DJAndries commented Jun 9, 2023 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

iefremov commented Jun 16, 2023

sangwoo108 left a comment

Choose a reason for hiding this comment

GeetaSarvadnya commented Jun 27, 2023 • edited Loading

Brave.VerticalTabs.OpenTabs

Brave.VerticalTabs.PinnedTabs

Brave.VerticalTabs.GroupTabs

Additional scenarios

DJAndries commented Jun 9, 2023 •

edited

Loading

GeetaSarvadnya commented Jun 27, 2023 •

edited

Loading