Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of # PR 18834 - The pinned tabs and tabgroups created in new window are not considered for the metrics response calculation #31368

Open
GeetaSarvadnya opened this issue Jun 28, 2023 · 2 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 28, 2023

Description

Found while testing brave/brave-core#18834
Follow up of # PR 18834 - The pinned tabs and tabgroups created in new window are not considered for the metrics response calculation

As a user with vertical tabs enabled and had at least one pinned tab this week, what is the max amount of pinned tabs this week?
`Brave.VerticalTabs.PinnedTabs`

0. 1-2
1. 3-5
2. 6+

As a user with vertical tabs mode enabled and had at least one tab group this week, what is the max amount of tab groups this week?
`Brave.VerticalTabs.GroupTabs`

0. 1-2
1. 3-5
2. 6+

Steps to Reproduce

Case 1:

  1. Clean profile 1.55.17
  2. Enable vertical tabs view
  3. Load 2 sites in 2 tabs
  4. Pin both the tabs
  5. Confirm that the metrics Brave.VerticalTabs.PinnedTabs response value is 0 as expected
  6. Right click on any pinned tab in vertical tab view and select the Move tab to another window context menu
  7. Confirm that the pinned tab is moved to the new window
  8. Add second tab in new window and pin it (step 6 window)
  9. Confirm that the total tabs pinned in the original window and new window is 3
  10. Reload brave://local-state file
  11. the metrics Brave.VerticalTabs.PinnedTabs response value is 0 instead of 1

Case 2:

  1. Clean profile 1.55.17
  2. Enable vertical tabs view
  3. Load 2 sites in 2 tabs
  4. Create two tab groups (Group 1 and Group 2)
  5. Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 0 as expected
  6. Right click on any tabgroup in vertical tab view and select the Move tab to another window context menu
  7. Confirm that the tabgroup is moved to the new window
  8. Add second tab in new window and create a 3rd tab gropu (step 6 window)
  9. Confirm that the total tabgroups in the original window and new window is 3
  10. Reload brave://local-state file
  11. the metrics Brave.VerticalTabs.PinnedTabs response value is 0 instead of 1

image

Actual result:

The pinned tabs and tabgroups created in new window are not considered for the metrics response calculation

Expected result:

The pinned tabs and tabgroups created in new window should be considered for the metrics response calculation

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.55.17 Chromium: 115.0.5790.40 (Official Build) nightly (64-bit)
Revision 071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS Windows 10 Version 22H2 (Build 19045.3086)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mattmcalister @DJAndries

@DJAndries
Copy link
Collaborator

I added a test plan. In order to trigger the internal Chromium tab model callback to update the group/pinned metrics, one must switch to another tab on the window where the group or pin was created. If you click on one of the tabs in step 9, you will see that the metric is updated.

Of course the latent reporting isn't ideal, but since most users would continue to switch between tabs and interact with the window(s) after creating a group or pinning a tab, I'm not sure if this is worth addressing.

@GeetaSarvadnya
Copy link
Author

cc @rebron Could you look into this issue and prioritize the issue if it needs to be addressed? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants