You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found while testing brave/brave-core#18834
Follow up of # PR 18834 - The pinned tabs and tabgroups created in new window are not considered for the metrics response calculation
As a user with vertical tabs enabled and had at least one pinned tab this week, what is the max amount of pinned tabs this week?
`Brave.VerticalTabs.PinnedTabs`
0. 1-2
1. 3-5
2. 6+
As a user with vertical tabs mode enabled and had at least one tab group this week, what is the max amount of tab groups this week?
`Brave.VerticalTabs.GroupTabs`
0. 1-2
1. 3-5
2. 6+
Steps to Reproduce
Case 1:
Clean profile 1.55.17
Enable vertical tabs view
Load 2 sites in 2 tabs
Pin both the tabs
Confirm that the metrics Brave.VerticalTabs.PinnedTabs response value is 0 as expected
Right click on any pinned tab in vertical tab view and select the Move tab to another window context menu
Confirm that the pinned tab is moved to the new window
Add second tab in new window and pin it (step 6 window)
Confirm that the total tabs pinned in the original window and new window is 3
Reload brave://local-state file
the metrics Brave.VerticalTabs.PinnedTabs response value is 0 instead of 1
Case 2:
Clean profile 1.55.17
Enable vertical tabs view
Load 2 sites in 2 tabs
Create two tab groups (Group 1 and Group 2)
Confirm that the metrics Brave.VerticalTabs.GroupTabs response value is 0 as expected
Right click on any tabgroup in vertical tab view and select the Move tab to another window context menu
Confirm that the tabgroup is moved to the new window
Add second tab in new window and create a 3rd tab gropu (step 6 window)
Confirm that the total tabgroups in the original window and new window is 3
Reload brave://local-state file
the metrics Brave.VerticalTabs.PinnedTabs response value is 0 instead of 1
Actual result:
The pinned tabs and tabgroups created in new window are not considered for the metrics response calculation
Expected result:
The pinned tabs and tabgroups created in new window should be considered for the metrics response calculation
I added a test plan. In order to trigger the internal Chromium tab model callback to update the group/pinned metrics, one must switch to another tab on the window where the group or pin was created. If you click on one of the tabs in step 9, you will see that the metric is updated.
Of course the latent reporting isn't ideal, but since most users would continue to switch between tabs and interact with the window(s) after creating a group or pinning a tab, I'm not sure if this is worth addressing.
Description
Found while testing brave/brave-core#18834
Follow up of # PR 18834 - The pinned tabs and tabgroups created in new window are not considered for the metrics response calculation
Steps to Reproduce
Case 1:
1.55.17
Brave.VerticalTabs.PinnedTabs
response value is0
as expectedMove tab to another window
context menuBrave.VerticalTabs.PinnedTabs
response value is0
instead of1
Case 2:
1.55.17
Brave.VerticalTabs.GroupTabs
response value is0
as expectedMove tab to another window
context menuBrave.VerticalTabs.PinnedTabs
response value is0
instead of1
Actual result:
The pinned tabs and tabgroups created in new window are not considered for the metrics response calculation
Expected result:
The pinned tabs and tabgroups created in new window should be considered for the metrics response calculation
Reproduces how often:
Easy
Brave version (brave://version info)
Other Additional Information:
Miscellaneous Information:
cc: @brave/qa-team @rebron @mattmcalister @DJAndries
The text was updated successfully, but these errors were encountered: