Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical tabs p3a (uplift to 1.56.x) #19185

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Conversation

DJAndries
Copy link
Collaborator

Uplift of #18834
Resolves brave/brave-browser#30928

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@DJAndries DJAndries requested a review from a team as a code owner July 6, 2023 23:07
@DJAndries DJAndries force-pushed the vertical-tabs-p3a-1.56.x branch 2 times, most recently from a29875a to 8e46c83 Compare July 7, 2023 06:29
@DJAndries DJAndries force-pushed the vertical-tabs-p3a-1.56.x branch from 8e46c83 to 0cc8d6c Compare July 7, 2023 06:52
@kjozwiak kjozwiak added this to the 1.56.x - Release milestone Jul 7, 2023
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.56.x approved 👍 QA has verified the PR on Nightly as per #18834 (comment).

@kjozwiak kjozwiak merged commit 89506c2 into 1.56.x Jul 7, 2023
@kjozwiak kjozwiak deleted the vertical-tabs-p3a-1.56.x branch July 7, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants