You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found while testing brave/brave-core#18834
Follow up of # PR 18834 - Follow up of # PR 18834 - The tabs opened in PT and TOR windows are not considered for the metrics response calculation
Steps to Reproduce
Clean profile 1.55.17
Enable vertical tabs view
Add 7 sites in 7 tabs
Confirm that the metrics Brave.VerticalTabs.OpenTabs response value is 2 as expected
Open a PT window and add two tabs with sites loaded
Open a TOR window and add two tabs with sites loaded
Number tabs in all the 3 window types (Regular, PT and TOR window) is 11
Reload brave://local-state file
The metrics Brave.VerticalTabs.OpenTabs response value is 2 instead of 3
If we look at the metrics Brave.Core.TabCount it gives the correct reponse when tab count is 7 and 11
Actual result:
The tabs opened in PT and TOR windows are not considered for the metrics response calculation
Expected result:
Tabs opened in all the window types needs to be considered for the metrics response calculation
Please note that the issue is reproducible for the metrics Brave.VerticalTabs.GroupTabs and Brave.VerticalTabs.PinnedTabs also. The pinned and grouped tabs are not considered for the metrics repsonse calculation. I have just logged a common issue, while fixing this issue, these two metrics response needs to be fixed.
cc: @DJAndries
Description
Found while testing brave/brave-core#18834
Follow up of # PR 18834 - Follow up of # PR 18834 - The tabs opened in PT and TOR windows are not considered for the metrics response calculation
Steps to Reproduce
1.55.17
Brave.VerticalTabs.OpenTabs
response value is2
as expectedBrave.VerticalTabs.OpenTabs
response value is2
instead of3
Brave.Core.TabCount
it gives the correct reponse when tab count is7
and11
Actual result:
The tabs opened in PT and TOR windows are not considered for the metrics response calculation
Expected result:
Tabs opened in all the window types needs to be considered for the metrics response calculation
Reproduces how often:
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/qa-team @DJAndries @mattmcalister @rebron
The text was updated successfully, but these errors were encountered: