-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement welcome Brave Ads notification when user connects custodial account: tell user they're now earning, and clicking isn't required #29297
Comments
Desktop only for this is issue. Do not implement on Android. |
Is this notification expected to timeout the same way other push ad notifications do? or does it stay until the user explicitly closes it? |
@LaurenWags it should timeout the same as push, hopefully this is the case? Thanks |
@brave/qa-team when testing this, in addition to the test plan under brave/brave-core#17881 (comment), we should also verify the following:
We should also check the following scenarios:
|
1, 2, 3 are correct @LaurenWags. The criterion to show this notification is: Did user move from non-connected state to connected state? It does not include moving from loggedOut state to connected state. It does not include being in the connected state then updating Brave and remaining in the connected state. |
Verification PASSED on
Case 1. Default notification or Standarad notification_PASSED
Case 2. Custom notification_PASSED
Verified the additional cases mentioned via #29297 (comment) Case 1_PASSED
Case 2_PASSED
Case 3_PASSED
|
@GeetaSarvadnya @btlechowski this is fixed by @aseren recent fix which he has requested uplift. |
Verified with
Verified the test plan from brave/brave-core#17881 (comment) Logged #30510 Case 1. Default notification or Standard notification - PASSED
![]() Case 2. Custom notification - PASSED with follow up issue
Verified the additional cases mentioned via #29297 (comment) Case 1 - PASSED
|
Description
After user connects custodial account and transitions from non-connected state to connected state, show the following in a system notification (same format as Brave Ads push notifications):
Additional notes (edit)
cc: @ddvorin1 @tmancey
The text was updated successfully, but these errors were encountered: