Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement welcome Brave Ads notification when user connects custodial account: tell user they're now earning, and clicking isn't required #29297

Closed
Miyayes opened this issue Mar 24, 2023 · 9 comments · Fixed by brave/brave-core#17881

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 24, 2023

Description

After user connects custodial account and transitions from non-connected state to connected state, show the following in a system notification (same format as Brave Ads push notifications):

🎉 You’re now earning for Brave Ads!
For example, you earn whenever a notification like this appears on your screen. You don’t need to click to earn.

Additional notes (edit)

  • If not touched, should time out / disappear with same timing as an ad notification per @tmancey.

cc: @ddvorin1 @tmancey

@Miyayes Miyayes changed the title Implement welcome Brave Ads notification when user connects custodial account Implement welcome Brave Ads notification when user connects custodial account: tell user they're now earning, and clicking isn't required Mar 24, 2023
@Miyayes
Copy link
Collaborator Author

Miyayes commented Mar 29, 2023

Desktop only for this is issue. Do not implement on Android.

@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 29, 2023
@emerick emerick added this to the 1.52.x - Nightly milestone Apr 4, 2023
@LaurenWags
Copy link
Member

Is this notification expected to timeout the same way other push ad notifications do? or does it stay until the user explicitly closes it?

@tmancey
Copy link
Contributor

tmancey commented Apr 19, 2023

@LaurenWags it should timeout the same as push, hopefully this is the case? Thanks

@LaurenWags
Copy link
Member

LaurenWags commented May 10, 2023

@brave/qa-team when testing this, in addition to the test plan under brave/brave-core#17881 (comment), we should also verify the following:

We should also check the following scenarios:

  1. For a grandfathered unverified user in 1.51.x, when they upgrade to 1.52.x no notification is shown. However, if a custodial wallet is connected using 1.52.x, then the notification shows.
  2. For a user who is connected to a custodian in 1.51.x (not logged out/disconnected verified) and upgrades to 1.52.x, no notification is shown.
  3. For a user who is connected to a custodian in 1.51.x and is also in the logged out/disconnected verified state and upgrades to 1.52.x, they will still be in logged out/disconnected verified state after upgrading. When the user logs back into their custodian/re-connects to verified, no notification is shown.

cc @emerick @Miyayes to confirm the above

@Miyayes
Copy link
Collaborator Author

Miyayes commented May 10, 2023

1, 2, 3 are correct @LaurenWags. The criterion to show this notification is: Did user move from non-connected state to connected state?

It does not include moving from loggedOut state to connected state.

It does not include being in the connected state then updating Brave and remaining in the connected state.

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 15, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 15, 2023

Verification PASSED on

Brave | 1.52.94 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | Windows 10 Version 21H2 (Build 19044.2965)

Case 1. Default notification or Standarad notification_PASSED
  1. Clean profile 1.52.x
  2. Enable rewards and connect to a custodian
  3. Confirmed that default/standard notification is shown
  4. Confirmed that the content of the notification is as per the test plan
  5. Confirmed that the notification is auto dismissed after 2 mins (120 secs)
  6. Confirme that click on Close button closes the notification

image

Case 2. Custom notification_PASSED
  1. Clean profile 1.52.x
  2. Enable #brave-ads-custom-push-notifications-ads flag via brave://flags
  3. Enable rewards and connect to a custodian
  4. Confirmed that the custom ad notification is shown
  5. Confirmed that the content of the notification is as per the test plan
  6. Confirmed that the notification is auto dismissed after 2 mins (120 secs)
  7. Confirme that click on Close button closes the notification

image (1)


Verified the additional cases mentioned via #29297 (comment)

Case 1_PASSED
  1. Clean profile 1.47.x RC version
  2. Enable rewards and connect to a custodian
  3. Upgrade the profile to 1.51.x RC version
  4. Rename the profile to beta
  5. launch the beta 1.52.94
  6. Confirmed that custodian is in connected state and there is no notification shown on the UI
Case 2_PASSED
  1. Clean profile 1.51.x
  2. Enable rewards and connect to a custodian
  3. Upgrade the profile to 1.52.x
  4. Confirmed that the notification is NOT shown as expected
Case 3_PASSED
  1. Clean profile 1.51.x
  2. Enable rewards and connect to a custodian
  3. Remove integration between uphold and brave
  4. Upgrade the profile to 1.52.x
  5. Confirmed that the notification is NOT shown as expected

@GeetaSarvadnya
Copy link

@Miyayes @emerick : Click on the notification dismiss the ad notification, it doesn't open the landing page. Is this expected?

@GeetaSarvadnya GeetaSarvadnya removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 15, 2023
@tmancey
Copy link
Contributor

tmancey commented May 15, 2023

@GeetaSarvadnya @btlechowski this is fixed by @aseren recent fix which he has requested uplift.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 22, 2023
@LaurenWags
Copy link
Member

LaurenWags commented May 22, 2023

Verified with

Brave | 1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (x86_64)
-- | --
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS | macOS Version 13.4 (Build 22F66)

Verified the test plan from brave/brave-core#17881 (comment)

Logged #30510

Case 1. Default notification or Standard notification - PASSED
  1. Clean profile 1.52.x
  2. Enable rewards and connect to a custodian
  3. Confirmed that default/standard notification is shown
  4. Confirmed that the content of the notification is as per the test plan
  5. Confirmed that the notification is auto dismissed after 2 mins (120 secs)
  6. Confirmed that click on Close button closes the notification
  7. Confirmed clicking on the notification directs to https://support.brave.com/hc/en-us/articles/14648356808845.
OS Notification
Case 2. Custom notification - PASSED with follow up issue
  1. Clean profile 1.52.x
  2. Enable #brave-ads-custom-push-notifications-ads flag via brave://flags
  3. Enable rewards and connect to a custodian
  4. Confirmed that the custom ad notification is shown but text is truncated. Logged custom "welcome" notification text is truncated #30510.
  5. Confirmed that the content of the notification is as per the test plan
  6. Confirmed that the notification is auto dismissed after 2 mins (120 secs)
  7. Confirmed that click on Close button closes the notification
  8. Confirmed clicking on the notification directs to https://support.brave.com/hc/en-us/articles/14648356808845.
Example Example
1 2

Verified the additional cases mentioned via #29297 (comment)

Case 1 - PASSED
  1. Create a profile to be grandfathered unverified (see me if you need instructions on how to do this) using 1.51.x
  2. Rename the profile to beta
  3. launch with beta version 1.52.x
  4. Confirmed that there is no notification shown on the UI and you are still in grandfathered unverified state (no custodian)
  5. Connect a custodian and confirm that the notification shows
Step 1 Step 4 Step 5
1 2 3
Case 2 - PASSED
  1. Clean profile 1.51.x
  2. Enable rewards and connect to a custodian
  3. Upgrade the profile to 1.52.x
  4. Confirmed that the notification is NOT shown as expected
Step 2 Step 4
2 4
Case 3 - PASSED
  1. Clean profile 1.51.x
  2. Enable rewards and connect to a custodian
  3. Remove integration between uphold and brave
  4. Upgrade the profile to 1.52.x
  5. Confirmed that the notification is NOT shown as expected
  6. Reconnect custodian, confirm notification is not shown.
Step 3 Step 5 Step 6
3 5 6

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 23, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants