Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom "welcome" notification text is truncated #30510

Closed
LaurenWags opened this issue May 23, 2023 · 5 comments · Fixed by brave/brave-core#18583
Closed

custom "welcome" notification text is truncated #30510

LaurenWags opened this issue May 23, 2023 · 5 comments · Fixed by brave/brave-core#18583

Comments

@LaurenWags
Copy link
Member

LaurenWags commented May 23, 2023

Test Plan

Confirmed with @emerick @Miyayes the updated text for this notification should be:

🎉 You’re now earning!
You earn whenever a notification like this appears on your screen. You don’t need to click to earn.

Description

Follow up to #29297

When the custom ad notification flag is enabled for brave://flags/#brave-ads-custom-push-notifications-ads, and the welcome notification is shown (added with #29297), the full text doesn't display.

The full text does display when standard/OS notification is used, not custom notifications.

Steps to Reproduce

  1. Clean profile 1.52.x
  2. Enable #brave-ads-custom-push-notifications-ads flag via brave://flags
  3. Enable rewards and connect to a custodian
  4. Confirmed that the custom ad notification is shown, but full text is not displayed.

Actual result:

Custom Notification with truncated text:

custom

Expected result:

Full text to be shown like when using standard/default OS notifications:

macOS

Reproduces how often:

easily

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@emerick also noted that the default notification looks cramped. I'd imagine that once we get translations for this, some translations could push this text to be truncated as well.

cc @Miyayes

@kjozwiak
Copy link
Member

The above requires 1.52.110 or higher for 1.52.x verification👍

@LaurenWags
Copy link
Member Author

LaurenWags commented May 24, 2023

Verified with

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (x86_64)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | macOS Version 13.4 (Build 22F66)

Verified updated notification text as per issue description.
Confirmed updated notification text on default (OS) notification and custom notification (both light and dark themes).
Confirmed no text is truncated (English only for now, translations are not in yet).

Default OS Notification Custom Notification (Dark) Custom Notification (Light)
std notification - macOS custom notification - macOS custom notification - macOS 2

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 24, 2023
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 24, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 24, 2023

Verification PASSED using

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (64-bit)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Windows 11 Version 22H2 (Build 22621.1702)
  • Verified updated notification text as per issue description.
  • Confirmed updated notification text on default (OS) notification and custom notification (both light and dark themes).
  • Confirmed no text is truncated (English only for now, translations are not in yet).
Default OS Notification Custom Notification (Dark) Custom Notification (Light)
image image image

Note: Default OS notification shows close button where as Custom notifications do not have button but both have same text.

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 24, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.52.112 Chromium: 114.0.5735.35 (Official Build) (64-bit)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Windows 10 Version 22H2 (Build 19045.2965)

  • Verified updated notification text as per issue description.
  • Confirmed updated notification text on default (OS) notification and custom notification (both light and dark themes).
  • Confirmed no text is truncated (English only for now, translations are not in yet).
Default OS Notification Custom Notification (Dark) Custom Notification (Light)
image image image

@stephendonner
Copy link

stephendonner commented May 26, 2023

Setting as QA Pass-Linux, since I spun off the Linux-only issue in #30605.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment