-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom "welcome" notification text is truncated #30510
Labels
Milestone
Comments
25 tasks
7 tasks
The above requires |
Verification
Note: Default OS notification shows close button where as Custom notifications do not have button but both have same text. |
Verification PASSED on
|
Setting as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Test Plan
Confirmed with @emerick @Miyayes the updated text for this notification should be:
Description
Follow up to #29297
When the custom ad notification flag is enabled for brave://flags/#brave-ads-custom-push-notifications-ads, and the welcome notification is shown (added with #29297), the full text doesn't display.
The full text does display when standard/OS notification is used, not custom notifications.
Steps to Reproduce
Actual result:
Custom Notification with truncated text:
Expected result:
Full text to be shown like when using standard/default OS notifications:
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
@emerick also noted that the default notification looks cramped. I'd imagine that once we get translations for this, some translations could push this text to be truncated as well.
cc @Miyayes
The text was updated successfully, but these errors were encountered: