-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up to #29313: Clicking Reminder Notification yields no action #30281
Labels
bug
feature/ads
feature/rewards
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/exclude
Milestone
Comments
25 tasks
7 tasks
The above requires |
Verification
|
Brave | 1.52.103 Chromium: 113.0.5672.126 (Official Build) beta (x86_64) |
---|---|
Revision | c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202} |
OS | macOS Version 13.4 (Build 22F66) |
Steps:
- installed
1.52.103
- launched Brave using
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
- enabled Rewards and Ads
- viewed a notification ad
- clicked the notification ad
Confirmed:
- clicking on the 1st ad notification yielded
You earn when a Brave ads notifi...
notification - clicking on the above notification opens
https://support.brave.com/hc/en-us/articles/14648356808845
in a new tab
example | example | example | example | example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verification
|
Brave | 1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (64-bit) |
---|---|
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454} |
OS | Windows 10 Version 22H2 (Build 19045.2965) |
Steps:
1 installed 1.52.109
2. launched Brave using
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
- enabled Rewards/Ads
- viewed a notification ad
- clicked the notification ad
Confirmed:
- clicking on the 1st notification yielded
You earn when a Brave ads notifi...
notification - clicking on the above notification opens
https://support.brave.com/hc/en-us/articles/14648356808845
example | example | example |
---|---|---|
![]() |
![]() |
![]() |
Verification passed on
Verified test plan from the description Verified clicking on the reminder notification opens https://support.brave.com/hc/en-us/articles/14648356808845 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/ads
feature/rewards
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-All-Platforms
QA/Yes
release-notes/exclude
Follow up to #29313
Steps to Reproduce
Actual result:
Clicking Reminder Notification yields no action
Expected result:
Clicking Reminder Notification opens
https://support.brave.com/hc/en-us/articles/14648356808845
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
cc @tmancey @Miyayes @emerick
The text was updated successfully, but these errors were encountered: