Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reminder notification click. #18463

Merged
merged 1 commit into from
May 12, 2023
Merged

Fixed reminder notification click. #18463

merged 1 commit into from
May 12, 2023

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented May 11, 2023

Resolves brave/brave-browser#30281

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Clean profile
  2. Run Brave with
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. Enable rewards and ads
  2. View a notification ad
  3. Click the notification ad
  4. Click the Reminder Notification
  5. Check that https://support.brave.com/hc/en-us/articles/14648356808845 is opened in a new tab

@aseren aseren requested a review from a team as a code owner May 11, 2023 23:49
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@aseren aseren enabled auto-merge May 12, 2023 19:06
@aseren aseren merged commit 7fc6f6d into master May 12, 2023
@aseren aseren deleted the issues/30281 branch May 12, 2023 21:52
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 12, 2023
@btlechowski
Copy link

btlechowski commented May 15, 2023

Verification passed on

Brave 1.53.40 Chromium: 113.0.5672.92 (Official Build) nightly (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Ubuntu 18.04 LTS

Verified click on the Reminder notification open https://support.brave.com/hc/en-us/articles/14648356808845 in a new tab

image

aseren pushed a commit that referenced this pull request May 15, 2023
kjozwiak pushed a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow up to #29313: Clicking Reminder Notification yields no action
3 participants