Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display welcome notification when user connects external wallet #17881

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Apr 3, 2023

Resolves brave/brave-browser#29297

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

UI:

Standard notification:
standard-notification

Custom notification:
custom-notification

Test Plan:

  • Clean profile
  • Enable Rewards
  • Connect a wallet and verify notification looks correct
  • Clean profile
  • Enable custom ads notifications via brave://flags
  • Enable Rewards
  • Connect a wallet and verify notification looks correct

@emerick emerick requested a review from a team as a code owner April 3, 2023 13:52
@emerick emerick self-assigned this Apr 3, 2023
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@@ -645,6 +645,9 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext
<message name="IDS_BRAVE_ADS_NOTIFICATION_AD_ACCESSIBLE_NAME" desc="Text to be spoken when a notification ad is shown">
Brave Notification Ad
</message>
<message name="IDS_BRAVE_ADS_NOTIFICATION_EXTERNAL_WALLET_CONNECTED" desc="The notification to show when an external wallet is connected">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this text fit in both system and custom push notifications?

Copy link
Contributor Author

@emerick emerick Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fits in the standard notification, but it doesn't quite fit in the custom notification. I was thinking that what I can do (just) for custom notifications is pull the "yay" emoji and first sentence into the title and keep everything else as the body.

custom

I'm not sure why there's so much empty space above the title, though (unless that's just what the custom notification UI looks like on Windows?)

cc: @Miyayes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty space is expected for custom notifications, per Terry.

@emerick emerick force-pushed the emerick-rewards-welcome-ads-notification branch 2 times, most recently from c22a5bd to ff08171 Compare April 4, 2023 13:39
@emerick emerick requested a review from aseren April 4, 2023 13:43
@emerick emerick force-pushed the emerick-rewards-welcome-ads-notification branch 3 times, most recently from 0151030 to 553cf3e Compare April 4, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants