-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display welcome notification when user connects external wallet #17881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
app/brave_generated_resources.grd
Outdated
@@ -645,6 +645,9 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext | |||
<message name="IDS_BRAVE_ADS_NOTIFICATION_AD_ACCESSIBLE_NAME" desc="Text to be spoken when a notification ad is shown"> | |||
Brave Notification Ad | |||
</message> | |||
<message name="IDS_BRAVE_ADS_NOTIFICATION_EXTERNAL_WALLET_CONNECTED" desc="The notification to show when an external wallet is connected"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this text fit in both system and custom push notifications?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fits in the standard notification, but it doesn't quite fit in the custom notification. I was thinking that what I can do (just) for custom notifications is pull the "yay" emoji and first sentence into the title and keep everything else as the body.
I'm not sure why there's so much empty space above the title, though (unless that's just what the custom notification UI looks like on Windows?)
cc: @Miyayes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty space is expected for custom notifications, per Terry.
c22a5bd
to
ff08171
Compare
0151030
to
553cf3e
Compare
553cf3e
to
cd47c55
Compare
Resolves brave/brave-browser#29297
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
UI:
Standard notification:

Custom notification:

Test Plan: