Pull latest master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REST Spec PR 'Azure/azure-rest-api-specs#5936' REST Spec PR Author 'vamuzumd' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#5838' REST Spec PR Author 'asafst' REST Spec PR Last commit
* .NET SDK Resource Provider:'ContainerRegistry' REST Spec PR 'Azure/azure-rest-api-specs#5543' REST Spec PR Author 'mnltejaswini' REST Spec PR Last commit * .NET SDK Resource Provider:'ContainerRegistry' REST Spec PR 'Azure/azure-rest-api-specs#5543' REST Spec PR Author 'mnltejaswini' REST Spec PR Last commit
* [DevSpaces] 2019-04-01 API version update * Change version to 0.12.0-preview
* Setting up CI triggers, and moving to template parameters.
REST Spec PR 'Azure/azure-rest-api-specs#6006' REST Spec PR Author 'hitesh715' REST Spec PR Last commit
* .NET SDK Resource Provider:'EventGrid' REST Spec PR 'Azure/azure-rest-api-specs#6003' REST Spec PR Author 'ahamad-MS' REST Spec PR Last commit * .NET SDK Resource Provider:'EventGrid' REST Spec PR 'Azure/azure-rest-api-specs#6003' REST Spec PR Author 'ahamad-MS' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#6009' REST Spec PR Author 'yangyuan' REST Spec PR Last commit
* BotService: Bump nuget version * BotService: Update dependencies and fix build . test * BotService; Remove Msa app creation and update tests * Remove unused constant * BotService: Update test session records * BotService; bump nuget version and update release notes
- Fix issue with versioning number split - Always set OfficialBuildId property - Fix Azure.Identity to use VersionPrefix
REST Spec PR 'Azure/azure-rest-api-specs#6026' REST Spec PR Author 'jhendrixMSFT' REST Spec PR Last commit
* Removed eng/ path filter. * Removed sdk/core/ path filter (except from the sdk/core pipeline itself.
REST Spec PR 'Azure/azure-rest-api-specs#6039' REST Spec PR Author 'amagams' REST Spec PR Last commit
* .NET SDK Resource Provider:'StorageSync' REST Spec PR 'Azure/azure-rest-api-specs#5941' REST Spec PR Author 'afedyashov' REST Spec PR Last commit * .NET SDK Resource Provider:'StorageSync' REST Spec PR 'Azure/azure-rest-api-specs#5941' REST Spec PR Author 'afedyashov' REST Spec PR Last commit * .NET SDK Resource Provider:'StorageSync' REST Spec PR 'Azure/azure-rest-api-specs#5941' REST Spec PR Author 'afedyashov' REST Spec PR Last commit * .NET SDK Resource Provider:'StorageSync' REST Spec PR 'Azure/azure-rest-api-specs#5941' REST Spec PR Author 'afedyashov' REST Spec PR Last commit
* .NET SDK Resource Provider:'ServiceFabric' REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit * .NET SDK Resource Provider:'ServiceFabric' REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit * .NET SDK Resource Provider:'ServiceFabric' REST Spec PR 'Azure/azure-rest-api-specs#5852' REST Spec PR Author 'a-santamaria' REST Spec PR Last commit
* .NET SDK Resource Provider:'ContainerService' REST Spec PR 'Azure/azure-rest-api-specs#5949' REST Spec PR Author 'haitch' REST Spec PR Last commit * .NET SDK Resource Provider:'ContainerService' REST Spec PR 'Azure/azure-rest-api-specs#5949' REST Spec PR Author 'haitch' REST Spec PR Last commit
* Regenerated WebSites SDK for ANT80 REST API spec * Update assembly version for WebSites SDK * Update package release notes, fix assembly version * Record websites tests * Update Websites SDK version to 2.2.0 * Update PackageReleaseNotes
* regenerate SDK from jadrefke fork * update test to exercise skill.name * update package release notes * update skillset tests * regenerate test session records * regenerate from master branch * add back compat constructors to customizations * rename files and add comments for when customizations can be removed * bump version number
* initial set of changes for using nuget * more settings updates. Removing irrelevant properties * adding skip test for all test projects that were skipped earlier. removing irrelevant props, targets. Removed implicit executing init as default targets * making init target not to download legacy toolset * mac testing updates * fixing keyvault projects to remove unnecessary imports * fixing indentation for yml files * updating nuget package for new directory structure * disabling failing tests * adding missing files
General
- Ongoing review and updates to member visibility to reduce public scope and limit protected
members.
- Removal of some package references carried over from track one that have been determined to be
unnecessary.
- Inclusion of the BCL interfaces preview package and supporting dependencies to allow for IAsyncDisposable
use.
Architecture Board Review Feedback
- Hide `MaximumSizeInBytes` from the `EventBatchingOptions`, is it is associated with a feature
no longer in scope for the first preview.
- Rename of `ConnectionType` to `TransportType` to clarify semantics.
- Remove `RetrievalTimeUtc` from `EventData` to align members cross-language.
- Hide `SystemProperties` on `EventData` in order to present a more clear surface. Properties
from the system set have been hoisted to first class members of `EventData`. At this time, it
is believe that there are no additional metadata items sent by the service that we wish to expose to
callers.
- Hide `Credential` and `ClientOptions` on `EventHubClient`; these are internal state tracking members used
by the class and were not intended to be exposed to consumers.
- Rename `PartitionReceiver` to `EventReceiver` to better align terminology between senders and receivers. The
associated `CreatePartitionReceiver` member on `EventHubClient` was updated to `CreateReceiver` to reflect this
change.
- Refactor to rename "BatchLabel" to "PartitionKey" in all contexts, along with documentation updates to try and
add clarity to the meaning and semantics of it.
- Marked the `ReceiverOptions` member `DefaultMaximumReceiveWaitTime` as internal, allowing it to be hidden from consumers
without causing churn and instability in the current flow of options. _(This will be revisited post-preview to better
understand if it is needed at all and, if so, whether there is benefit to exposing it to consumers.)_
Event Hub Client
- Refactoring to tighten access modifier scopes; testing approach has been adjusted to make greater
use of custom mock objects and rely less on mocking via Moq to help limit the need for `protected`
members exposed only to allow internal testing.
- Added support for IAsyncDisposable, delegating to `CloseAsync` to allow for more consise and representative usage
patterns rather than requiring an explicit try/finally wrapper to ensure proper closure.
- Implemented construction of an inner transport client to use via containment as a delegate for performing
the operations requested by consumers.
- Wired up delegation to the active transport client to service operations requested of the `EventHubClient`.
- Introduced Live tests for basic operations directly on the `EventHubClient`, absent creating senders and receivers.
Transport Client
- Introduced as an abstraction to allow for a generalized Event Hub client interface specific to a
protocol/transport to be used for delegation of operations. It is intended that the public-facing
`EventHubClient` create a dedicated transport client based on the active set of client options and make
use if it via containment to avoid having protocol/transport concerns exposed.
- Created a transport client shim to serve as a bridge and adapter between the track two API and the track
one implementation, allowing the preview to delegate operations to the track one types.
Authorization
- Added a default duration for shared key credentials in support of connection string use.
Test Infrastructure
- Added an abstraction for running Live tests in an `EventHubScope`, which is intended to allow for dynamic creation
of an Event Hub with a given number of partitions, uniquely named. This will allow Live tests to run strictly sandboxed,
with a single test running against a give Hub.
**NOTE:** _This has not been fully implemented yet; currently, the structure is in place to allow for creating Live tests
in the structure that will be needed to avoid a large and sweeping refactoring when the management functionality is added._
* CognitiveServices NetworkRule support * bump CognitiveServices to 6.0.0
* refactoring Azure.Identity with Arch Board feedback * Fixing core and event hubs tests * updates addressing PR feedback
* generated with 2019-05-01/resources. * reset the generated files. * reset * generate again. * version bump. * Test recordings. * more recordings.
The Microsoft.Azure.CognitiveServices.Language.LUIS.Authoring project incorrectly had disabled GenerateAssemblyInfo and as a result the version and copyright information was not correctly embedded into the assembly.
General
- Ongoing review and updates to member visibility to reduce public scope and limit protected
members.
- Shifting to a reflection-based approach over `internal` members for areas where the testing
is focused in a tight scope.
Track One Token Provider
- Allowed for sub-paths of an event hub instance to be considered valid, which is needed for support
of partition-based senders and receivers.
Event Sender
- Fleshed out the prototype skeleton to complete functionality using an abstraction for the
transport-level concerns, making use of a compatibility shim to bridge to the track one
`EventDataSender`.
Event Data Sender (Track One)
- Moved diagnostics and logging functionality into the core `EventDataSender` and out of the
consuming classes (`PartitionSender` and `EventHubClient`) to remove duplication and allow
the track two implementation to make use of the functionality implicitly.
Live Tests
- Added basic scenarios around the sending of events to smoke test the end-to-end scenarios;
these will be extended with more complete coverage in a future workstream.
* Updating Project files to accomodate management libraries in the sdk directory * Move and Restructure MachineLearninigCompute * Modify Mgmt build tools, Update machinelearningcompute service * Moved First sectionof Management Plane * Updates to 3 Services * Update to service folders * Updated files * Moved ref files into mgmt directory * Update Import Paths * Move services with DataPlane Move services with Mgmt Plane * Identified and Isolated Services with errors * Moved Projects with Errors * Fix to diffs between sdk and sdks after rebase from upstream * Move Azure Stack * Moved Storage Management * Renamed azure-kusto to kusto * Incorporate new mgmt changes * Dumped new PR changes * Fix for missing readmes * Remove warn As Error from ci yml * Update exclude in service.proj
…n string (Part 2) (#6037) * Fixes #6032 Azure/azure-service-bus-dotnet#482 * Approving public API changes
* ServiceBus SDK: Rbac support * CR comments * CR comments 2 * Use string instead of enum for AuthenticationType * Connectionstring support for management client * PR comments * Fix API Approval Tests
- Fixes the Azure.Core issue which shouldn't be included in mgmt libraries - Fix long path issues with location services by renaming namespace - Fix output paths to go under artifacts folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.