Nug tools #6499
Merged
Nug tools #6499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 16, 2019 13:51
…oving irrelevant props, targets. Removed implicit executing init as default targets
weshaggard
reviewed
Jun 10, 2019
| @@ -22,6 +22,7 @@ tools/Microsoft.WindowsAzure.Build.Tasks/packages/ | |||
| PublishedNugets/ | |||
| src/NuGet.Config | |||
| tools/7-zip/ | |||
| #tools/LocalNugetFeed/Microsoft.Internal.NetSdkBuild.Mgmt.Tools.*.nupkg | |||
There was a problem hiding this comment.
Is this still needed now that we published the tools package?
weshaggard
reviewed
Jun 10, 2019
| <config> | ||
| <add key="globalPackagesFolder" value="restoredPackages" /> |
There was a problem hiding this comment.
Is it still a goal to remove these changes in a follow-up?
weshaggard
reviewed
Jun 10, 2019
|
|
||
| <ItemGroup Condition="'$(IsTargetingNetStandard)' == 'true'"> | ||
| <PackageReference Include="System.Net.Http" Version="4.3.0"/> | ||
| <PackageReference Include="Newtonsoft.Json" Version="10.0.3" /> |
There was a problem hiding this comment.
I think the data-plane builds are failing because of this removal. In particular I believe they need this Newtonsoft.Json reference.
weshaggard
reviewed
Jun 10, 2019
| @@ -1,5 +1,5 @@ | |||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.props'))" /> | |||
| <!-- <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.props'))" /> --> | |||
weshaggard
reviewed
Jun 10, 2019
| filename: C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.2 Tools\sn.exe | ||
| arguments: -Vr *,31bf3856ad364e35 | ||
| displayName: 'Disable strong name verification' | ||
| # - task: CmdLine@1 |
There was a problem hiding this comment.
I'd suggest removing instead of commenting out.
|
@shahabhijeet this PR did break the data-plane builds. You added the files back but you added them under the eng/mgmt directory instead of the eng directory. I'm going to fix that right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make couple of fundamental changes the way management SDKs will be built
Changes:
Their will not be any need moving forward to download build tools by executing msbuild build.proj
1.1 Build tools will be downloaded implicitly
1.2 If you ever need to refresh build tools, you will need to delete the following directory rootDir\restoredPackages\microsoft.internal.NetSdkBuild.Mgmt.Tools directory and execute your build target again.
All existing scenarios to build SDKs are at parity with previous tool set.
Moving forward due to directory restructure, scope path will have to be changed appropriately (documentation will be updated in the next PR)
3.1 Instead of /p:Scope=SDKs\Compute
3.2 /p:Scope=sdk\compute\microsoft.azure.management.compute
3.3 /p:Scope=sdk\compute /p:ProjectCategory=mgmt
This does not support data-plane SDK projects (it might work, but not thoroughly tested, as communicated earlier that data plane SDK projects will not participate in this tool set)
Move all management specific targets under eng\mgmt
Update repo with the right set of test projects that we skipped in the CI jenkins job, now each project has an explicit property to skip tests
TODO:
Consolidate base targets (e.g. Clean, Build, ReBuild) with data plane targets
Workaround is to introduce new mgmtBuild.proj for building management plane SDKs
Lot of bugs/oddities will be squeezed out once the new directory structure is in place.
Block packages to be published if tests are skipped