Impossible to know if underlying connection is shared or not

[SeanFeldman]

When clients are created, they can be instantiated with a connection-string or a connection.
The second method allows connection sharing. It is also exposed via IClientEntity.ServiceBusConnection. Unfortunately, there's no was to know if connection is owned by a client or not.

In scenarios, where a decision has to be made based on the fact that a client does or does not own a connection, there's no way to determine that information. The information is stored internally on each client, and could be exposed via IClientEntity as a read-only property.

Suggestion - expose OwnsConnection read-only property on IClientEntity for all clients to implement.

Modifying IClientEntity would cause a breaking change and require a new major version.
Alternative route would be to introduce OwnsConnection in a minor release and expose as part of the
IClientEntity interface in the next major.

Versions

• NuGet package version or commit ID: 3.0.2

[nemakam]

What is the real-world use case here?
You have created your own client. So you already do know which one is shared, and which one is not.

[SeanFeldman]

What is the real-world use case here?

Trying to implement MessageSender pooling and when returning a message sender back, information required to determine what to do about the returned sender is not enough.

You have created your own client. So you already do know which one is shared, and which one is not.

In an application that span a larger code base, getting a sender from a pool (creation) and returning (verification that sender owns its connection) are not necessarily related.

[SeanFeldman]

@nemakam I could send a PR if you'd like.

[nemakam]

@SeanFeldman
Sure. So if I understand correctly, you will have to send 2 PRs. One with the property exposing in ClientEntity, which can go anytime.
Another one that would go to IClientEntity that will be checked in along with other breaking changes.

[SeanFeldman]

Yep. Exactly that. Will send the PRs shortly.