-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow clients to report if they own or share the underlying connection string (Part 2) #6037
Allow clients to report if they own or share the underlying connection string (Part 2) #6037
Conversation
Can one of the admins verify this patch? |
@jsquire @AlexGhiondea have you had a chance to triage this one? |
Ping |
I don't have good insight into the current plans for the next Service Bus release, as I'm focused elsewhere at present. I'll need to defer to @AlexGhiondea, who will have better insight. |
Hey @SeanFeldman! As we don't yet have sufficient context on this, I am adding @binzywu and @makam to take a look. |
@AlexGhiondea have you had a chance to connect with the broker team? |
I'll have to continue to defer to @AlexGhiondea for insight regarding conversations with the service team. However, I assigned the issue, applied tags, and tagged reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that my comment on the IClientEntity
type is correct, this looks like a good idea to me, for the next major.
@makam: I'd appreciate your thoughts.
@SeanFeldman: I didn't see any objections and the change seems reasonable to me; I merged it in so that it'll go with the pending set of breaking changes. |
Fixes #6032
Breaking change. Should be merged for the next major.