Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clients to report if they own or share the underlying connection string (Part 2) #6037

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Allow clients to report if they own or share the underlying connection string (Part 2) #6037

merged 2 commits into from
Jun 12, 2019

Conversation

SeanFeldman
Copy link
Contributor

@SeanFeldman SeanFeldman commented May 1, 2019

Fixes #6032

Breaking change. Should be merged for the next major.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@SeanFeldman
Copy link
Contributor Author

@jsquire @AlexGhiondea have you had a chance to triage this one?

@SeanFeldman
Copy link
Contributor Author

Ping

@jsquire
Copy link
Member

jsquire commented May 20, 2019

I don't have good insight into the current plans for the next Service Bus release, as I'm focused elsewhere at present. I'll need to defer to @AlexGhiondea, who will have better insight.

@AlexGhiondea
Copy link
Contributor

Hey @SeanFeldman! As we don't yet have sufficient context on this, I am adding @binzywu and @makam to take a look.

@SeanFeldman
Copy link
Contributor Author

SeanFeldman commented Jun 12, 2019

@AlexGhiondea have you had a chance to connect with the broker team?
Would be nice to have this PR labelled with Client, Service Bus, and breaking-change to indicate what it stands for. Similar to #6393, which is also a breaking change PR for the ASB client.

@jsquire jsquire added breaking-change Client This issue points to a problem in the data-plane of the library. Service Bus labels Jun 12, 2019
@jsquire jsquire assigned jsquire and nemakam and unassigned jsquire Jun 12, 2019
@jsquire
Copy link
Member

jsquire commented Jun 12, 2019

I'll have to continue to defer to @AlexGhiondea for insight regarding conversations with the service team. However, I assigned the issue, applied tags, and tagged reviewers.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that my comment on the IClientEntity type is correct, this looks like a good idea to me, for the next major.

@makam: I'd appreciate your thoughts.

@jsquire jsquire merged commit ba0e653 into Azure:master Jun 12, 2019
@jsquire
Copy link
Member

jsquire commented Jun 12, 2019

@SeanFeldman: I didn't see any objections and the change seems reasonable to me; I merged it in so that it'll go with the pending set of breaking changes.

@SeanFeldman SeanFeldman deleted the expose-owns-connection-on-icliententity branch June 12, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
5 participants