Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ekf_localizer): change roll, pitch proc dev #8619

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Aug 26, 2024

Description

In this PR, since the squared value is now set, like

roll_filter_.set_proc_var(params_.roll_filter_proc_dev * params_.roll_filter_proc_dev);

So the parameter value has been adjusted by taking the square root.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

test with autowarefoundation/autoware_launch#1140

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Aug 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.10%. Comparing base (c80eddc) to head (9709333).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8619   +/-   ##
=======================================
  Coverage   24.10%   24.10%           
=======================================
  Files        1399     1399           
  Lines      102455   102448    -7     
  Branches    38921    38917    -4     
=======================================
  Hits        24695    24695           
+ Misses      75235    75228    -7     
  Partials     2525     2525           
Flag Coverage Δ *Carryforward flag
differential 31.43% <ø> (?)
total 24.10% <ø> (-0.01%) ⬇️ Carriedforward from c80eddc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit f99aa3a into autowarefoundation:main Aug 26, 2024
43 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
)

change roll, pitch proc dev

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
)

change roll, pitch proc dev

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 16, 2024
)

change roll, pitch proc dev

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
)

change roll, pitch proc dev

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants