refactor(ekf_localizer): rename dev to var in the Simple1DFilter class #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
SakodaShintaro
approved these changes
Aug 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8576 +/- ##
=======================================
Coverage 23.99% 24.00%
=======================================
Files 1384 1384
Lines 102173 102179 +6
Branches 38956 38959 +3
=======================================
+ Hits 24520 24525 +5
Misses 75180 75180
- Partials 2473 2474 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
autowarefoundation#8576) rename dev to var Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
autowarefoundation#8576) rename dev to var Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
autowarefoundation#8576) rename dev to var Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The variable dev_ in Simple1DFilter is being treated as variance, not standard deviation.
So, I have renamed
devtovarin the Simple1DFilter classRelated links
Parent Issue:
How was this PR tested?
Lsim works
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.