-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(elevation_map_loader): modify build error in rolling #780
fix(elevation_map_loader): modify build error in rolling #780
Conversation
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Codecov Report
@@ Coverage Diff @@
## main #780 +/- ##
=====================================
Coverage 9.63% 9.63%
=====================================
Files 907 907
Lines 56544 56544
Branches 6694 6694
=====================================
Hits 5450 5450
Misses 46599 46599
Partials 4495 4495
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -67,7 +67,7 @@ class ElevationMapLoaderNode : public rclcpp::Node | |||
rclcpp::Publisher<grid_map_msgs::msg::GridMap>::SharedPtr pub_elevation_map_; | |||
rclcpp::Publisher<sensor_msgs::msg::PointCloud2>::SharedPtr pub_elevation_map_cloud_; | |||
void onPointcloudMap(const sensor_msgs::msg::PointCloud2::ConstSharedPtr pointcloud_map); | |||
void onMapHash(const tier4_external_api_msgs::msg::MapHash::SharedPtr map_hash); | |||
void onMapHash(const tier4_external_api_msgs::msg::MapHash::ConstSharedPtr map_hash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wep21 Could you add some reference links to the description if you know? 🙏
* use point cloud msg wrapper * fix CMakeList * fix format * fix bug * refactor code to reduce calculation cost * format code * change point types namespace * remove unnecessary declaration * add point_cloud_msg_wrapper dependency Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
make install_devel true Signed-off-by: Yuxuan Liu <uken.ryu.2@tier4.jp> Co-authored-by: Yuxuan Liu <uken.ryu.2@tier4.jp>
* change params Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.