Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elevation_map_loader): modify build error in rolling #780

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix(elevation_map_loader): modify build error in rolling #780

merged 1 commit into from
Apr 25, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 24, 2022

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 requested review from kenji-miyake and esteve April 24, 2022 16:02
@wep21 wep21 added ros:humble ROS Humble Hawksbill release. ros:rolling Continuous ROS Rolling Ridley release. labels Apr 24, 2022
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #780 (959f3db) into main (12c6492) will not change coverage.
The diff coverage is 50.00%.

@@          Coverage Diff          @@
##            main    #780   +/-   ##
=====================================
  Coverage   9.63%   9.63%           
=====================================
  Files        907     907           
  Lines      56544   56544           
  Branches    6694    6694           
=====================================
  Hits        5450    5450           
  Misses     46599   46599           
  Partials    4495    4495           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 9.63% <50.00%> (ø) Carriedforward from 12c6492

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...elevation_map_loader/elevation_map_loader_node.hpp 0.00% <ø> (ø)
...ation_map_loader/src/elevation_map_loader_node.cpp 0.00% <ø> (ø)
.../src/fault_injection_node/fault_injection_node.cpp 34.69% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35e31c...959f3db. Read the comment docs.

@wep21 wep21 enabled auto-merge (squash) April 24, 2022 16:57
@wep21 wep21 merged commit ced5c0d into autowarefoundation:main Apr 25, 2022
@@ -67,7 +67,7 @@ class ElevationMapLoaderNode : public rclcpp::Node
rclcpp::Publisher<grid_map_msgs::msg::GridMap>::SharedPtr pub_elevation_map_;
rclcpp::Publisher<sensor_msgs::msg::PointCloud2>::SharedPtr pub_elevation_map_cloud_;
void onPointcloudMap(const sensor_msgs::msg::PointCloud2::ConstSharedPtr pointcloud_map);
void onMapHash(const tier4_external_api_msgs::msg::MapHash::SharedPtr map_hash);
void onMapHash(const tier4_external_api_msgs::msg::MapHash::ConstSharedPtr map_hash);
Copy link
Contributor

@kenji-miyake kenji-miyake Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wep21 Could you add some reference links to the description if you know? 🙏

@wep21 wep21 deleted the fix/rolling-elevation-map-loader branch April 25, 2022 01:59
h-ohta referenced this pull request in h-ohta/autoware.universe Apr 26, 2022
* use point cloud msg wrapper

* fix CMakeList

* fix format

* fix bug

* refactor code to reduce calculation cost

* format code

* change point types namespace

* remove unnecessary declaration

* add point_cloud_msg_wrapper dependency

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
make install_devel true

Signed-off-by: Yuxuan Liu <uken.ryu.2@tier4.jp>
Co-authored-by: Yuxuan Liu <uken.ryu.2@tier4.jp>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
* change params

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros:humble ROS Humble Hawksbill release. ros:rolling Continuous ROS Rolling Ridley release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants