Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from autowarefoundation:main #780

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 24, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

sasakisasaki and others added 6 commits January 24, 2025 17:06
* feat(system_monitor): apply `autoware_` prefix (see below):

  * The `system_monitor` operates independently from other modules in `autoware.universe`, so the `autoware_` prefix is added only to the package name.
  * The `autoware::` namespace is not used because C language does not support namespaces.
  * Headers are not moved under `include/autoware` to maintain compatibility for use outside the `autoware` context.
  * For users utilizing this package within `autoware.universe`, only the package name includes the `autoware_` prefix.

This approach explains the unique namespacing and naming conventions for `system_monitor` compared to other packages.

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>

* bug(system_monitor): fix missing package name update

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>

* rename: `system_monitor` => `autoware_system_monitor`

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>

* style(pre-commit): autofix

* update: `CODEOWNERS`

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>

* bug(autoware_system_monitor): apply missing fix

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>

* update: `CODEOWNERS`

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>

---------

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
)

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: SakodaShintaro <rgbygscrsedppbwg@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
)

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…9936)

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@pull pull bot added the ⤵️ pull label Jan 24, 2025
@pull pull bot merged commit 5872113 into h-ohta:main Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant