-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply autoware_
prefix for evaluator/kinematic_evaluator
#9936
feat: apply autoware_
prefix for evaluator/kinematic_evaluator
#9936
Conversation
* In this commit, I did not organize a folder structure. The folder structure will be organized in the next some commits. Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…include/autoware`: * Fixes due to this changes for .hpp/.cpp files will be applied in the next commit Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…mmit Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
autoware_
prefix for evaluator kinematic evaluator
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
autoware_
prefix for evaluator kinematic evaluatorautoware_
prefix for evaluator/kinematic_evaluator
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9936 +/- ##
==========================================
- Coverage 29.78% 29.53% -0.25%
==========================================
Files 1435 1430 -5
Lines 108277 107813 -464
Branches 42946 42824 -122
==========================================
- Hits 32249 31847 -402
+ Misses 72898 72897 -1
+ Partials 3130 3069 -61
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…ematic-evaluator Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…uator' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-evaluator-kinematic-evaluator Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
The evaluator result (TIER IV Internal link): |
Description
This pull request addresses the issue of inconsistent naming by adding the
autoware_
prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.Related Links
How was this PR tested?
Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.
Executed Commands (which succeeded)
Directory Name
autoware_
as a prefix to the directory name.packages.xml
autoware_
to thename
element.CMakeLists.txt
project
name toautoware_***
.autoware::
toPLUGIN
.Header Files (.hpp)
#ifndef
guards withAUTOWARE__
.autoware::
tonamespace
.Source Files (.cpp)
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.Launch Files
autoware_
beforefind-pkg-share
.node pkg="<pkgname>"
toautoware_<pkgname>
.Include
autoware
folder as necessary and update include statements accordingly.Verification Points
find-pkg-share
in autowaresensor_launch
as seen ingnss_poser
Notes for Reviewers
None.
Interface Changes
None.
Effects on System Behavior
All the developers who were using
kinematic_evaluator
needs to modify their code. This is maybe kind of non quick-win task.