Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple_planning_simulator): add new vehicle model with falling down #7651

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jun 24, 2024

Description

This PR provides a new vehicle model that may fall against the slope without appropriate brake control.

The new model is forked from the model delay_steer_acc_geared, and its significant change is brake behavior.
The new model can handle more appropriate brake acceleration when the vehicle has zero or negative velocity against the gear.

In addition, I also fixed a problem where the slope compensations sign was reversed when backing up, which is common to all models.
Screencast from 06-25-2024 02:24:59 PM.webm

Related links

Tests performed

psim

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Jun 24, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title feal(simple_planning_simulator): enable falling down feal(simple_planning_simulator): add new vehicle model with falling down Jun 24, 2024
@yuki-takagi-66 yuki-takagi-66 force-pushed the feat/psim/enable-falling-down branch from 0ef8a26 to 075ff4a Compare June 24, 2024 07:42
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review June 24, 2024 07:43
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 24, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title feal(simple_planning_simulator): add new vehicle model with falling down feat(simple_planning_simulator): add new vehicle model with falling down Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 86.79245% with 14 lines in your changes missing coverage. Please review.

Project coverage is 8.46%. Comparing base (507e3f4) to head (15ce9d0).
Report is 169 commits behind head on main.

Files Patch % Lines
...sim_model_delay_steer_acc_geared_wo_fall_guard.cpp 85.86% 9 Missing and 4 partials ⚠️
...nning_simulator/simple_planning_simulator_core.cpp 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7651       +/-   ##
==========================================
- Coverage   14.84%   8.46%    -6.38%     
==========================================
  Files        1999     106     -1893     
  Lines      139163   10355   -128808     
  Branches    43716    1268    -42448     
==========================================
- Hits        20661     877    -19784     
+ Misses      95731    9449    -86282     
+ Partials    22771      29    -22742     
Flag Coverage Δ
differential 8.46% <86.79%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 force-pushed the feat/psim/enable-falling-down branch from 7008f23 to 7b53324 Compare June 24, 2024 08:16
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 force-pushed the feat/psim/enable-falling-down branch from 7b53324 to b536939 Compare June 25, 2024 05:16
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me and I tested Psim and did not observe any problem.

Can you update the README with a small description of the new model ?

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 merged commit c7f2e1e into autowarefoundation:main Jun 27, 2024
29 of 31 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/psim/enable-falling-down branch June 27, 2024 08:24
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jul 3, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jul 4, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jul 4, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jul 9, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…own (#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jul 24, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
saka1-s pushed a commit to tier4/autoware.universe that referenced this pull request Jul 25, 2024
* feat(simple_planning_simulator): add new vehicle model with falling down (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* refactor(vehicle_cmd_gate)!: delete rate limit skipping function for vehicle departure (autowarefoundation#7720)

* delete a fucntion block. More appropriate function can be achieved by the parameter settings.
* add notation to readme
---------
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

* feat(pid_longitudinal_controller): re-organize diff limit structure and fix state change condition (autowarefoundation#7718)

change diff limit structure
change stopped condition
define a new param

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>

---------

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2024
…own (autowarefoundation#7651)

* add new vehicle model

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants