-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(simple_planning_simulator): add new vehicle model with falling down #7651
feat(simple_planning_simulator): add new vehicle model with falling down #7651
Conversation
0ef8a26
to
075ff4a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7651 +/- ##
==========================================
- Coverage 14.84% 8.46% -6.38%
==========================================
Files 1999 106 -1893
Lines 139163 10355 -128808
Branches 43716 1268 -42448
==========================================
- Hits 20661 877 -19784
+ Misses 95731 9449 -86282
+ Partials 22771 29 -22742
☔ View full report in Codecov by Sentry. |
7008f23
to
7b53324
Compare
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
7b53324
to
b536939
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me and I tested Psim and did not observe any problem.
Can you update the README with a small description of the new model ?
...e/simple_planning_simulator/vehicle_model/sim_model_delay_steer_acc_geared_wo_fall_guard.hpp
Outdated
Show resolved
Hide resolved
...c/simple_planning_simulator/vehicle_model/sim_model_delay_steer_acc_geared_wo_fall_guard.cpp
Outdated
Show resolved
Hide resolved
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
c7f2e1e
into
autowarefoundation:main
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> Signed-off-by: palas21 <palas21@itu.edu.tr>
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…own (#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
* feat(simple_planning_simulator): add new vehicle model with falling down (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * refactor(vehicle_cmd_gate)!: delete rate limit skipping function for vehicle departure (autowarefoundation#7720) * delete a fucntion block. More appropriate function can be achieved by the parameter settings. * add notation to readme --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> * feat(pid_longitudinal_controller): re-organize diff limit structure and fix state change condition (autowarefoundation#7718) change diff limit structure change stopped condition define a new param Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp> --------- Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
…own (autowarefoundation#7651) * add new vehicle model Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Description
This PR provides a new vehicle model that may fall against the slope without appropriate brake control.
The new model is forked from the model
delay_steer_acc_geared
, and its significant change is brake behavior.The new model can handle more appropriate brake acceleration when the vehicle has zero or negative velocity against the gear.
In addition, I also fixed a problem where the slope compensations sign was reversed when backing up, which is common to all models.
Screencast from 06-25-2024 02:24:59 PM.webm
Related links
Tests performed
psim
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.