fix(simple_planning_simulator): fix acc output for the model sim_model_delay_steer_acc_geared_wo_fall_guard #8607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
maxime-clem
approved these changes
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8607 +/- ##
==========================================
- Coverage 24.06% 24.06% -0.01%
==========================================
Files 1398 1400 +2
Lines 102639 102668 +29
Branches 39023 39024 +1
==========================================
+ Hits 24704 24710 +6
- Misses 75403 75426 +23
Partials 2532 2532
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…l_delay_steer_acc_geared_wo_fall_guard (autowarefoundation#8607) fix acceleration output Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
…l_delay_steer_acc_geared_wo_fall_guard (autowarefoundation#8607) fix acceleration output Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
…l_delay_steer_acc_geared_wo_fall_guard (autowarefoundation#8607) fix acceleration output Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recently added vehicle model sim_model_delay_steer_acc_geared_wo_fall_guard has a bug that publish the input acc_cmd as the current acceleration. #7651
This PR fix this issue.
Related links
How was this PR tested?
psim
Notes for reviewers
I know the zero division line is newly added by this PR.
Interface changes
None.
Effects on system behavior
None.