Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): refactor isAllowedGoalModification #4856

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 3, 2023

Description

remove left_side args from isAllowedGoalModification

Tests performed

psim
scnerio test
https://evaluation.tier4.jp/evaluation/reports/9058babd-3979-555b-9559-48ef2ca1d3f4?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 force-pushed the refactor/is_allow_goal_modification branch from 3c67752 to 55e15f0 Compare September 3, 2023 14:25
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the refactor/is_allow_goal_modification branch from afb9001 to cf9dc97 Compare September 4, 2023 05:19
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 6.81% and no project coverage change.

Comparison is base (b255111) 15.11% compared to head (cf9dc97) 15.12%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4856    +/-   ##
========================================
  Coverage   15.11%   15.12%            
========================================
  Files        1578     1578            
  Lines      108631   108979   +348     
  Branches    33351    33601   +250     
========================================
+ Hits        16418    16478    +60     
- Misses      74316    74552   +236     
- Partials    17897    17949    +52     
Flag Coverage Δ *Carryforward flag
differential 13.06% <6.81%> (?)
total 15.11% <ø> (+<0.01%) ⬆️ Carriedforward from b255111

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...path_planner/scene_module/goal_planner/manager.hpp 100.00% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
..._path_planner/src/marker_utils/avoidance/debug.cpp 5.16% <ø> (+0.03%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.36% <0.00%> (-0.05%) ⬇️
.../scene_module/goal_planner/goal_planner_module.cpp 5.94% <0.00%> (+0.03%) ⬆️
..._planner/src/scene_module/goal_planner/manager.cpp 8.91% <0.00%> (-1.03%) ⬇️
sensing/imu_corrector/src/gyro_bias_estimator.cpp 0.00% <ø> (ø)
sensing/imu_corrector/src/imu_corrector_core.cpp 0.00% <ø> (ø)
...ilter_node/radar_static_pointcloud_filter_node.cpp 0.00% <ø> (ø)
...avior_path_planner/src/utils/goal_planner/util.cpp 10.52% <42.85%> (-1.02%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 changed the title ractor(goal_planner): refactor isAllowedGoalModification refactor(goal_planner): refactor isAllowedGoalModification Sep 4, 2023
@kosuke55 kosuke55 merged commit 51af068 into main Sep 4, 2023
@kosuke55 kosuke55 deleted the refactor/is_allow_goal_modification branch September 4, 2023 11:06
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 7, 2023
…oundation#4856)

* ractor(goal_planner): refactor isAllowedGoalModification

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix build

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…oundation#4856)

* ractor(goal_planner): refactor isAllowedGoalModification

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix build

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
…oundation#4856)

* ractor(goal_planner): refactor isAllowedGoalModification

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix build

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants