-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(goal_planner): refactor isAllowedGoalModification #4856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3c67752
to
55e15f0
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
afb9001
to
cf9dc97
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4856 +/- ##
========================================
Coverage 15.11% 15.12%
========================================
Files 1578 1578
Lines 108631 108979 +348
Branches 33351 33601 +250
========================================
+ Hits 16418 16478 +60
- Misses 74316 74552 +236
- Partials 17897 17949 +52
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…oundation#4856) * ractor(goal_planner): refactor isAllowedGoalModification Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix build Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…oundation#4856) * ractor(goal_planner): refactor isAllowedGoalModification Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix build Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…oundation#4856) * ractor(goal_planner): refactor isAllowedGoalModification Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix build Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
remove
left_side
args fromisAllowedGoalModification
Tests performed
psim
scnerio test
https://evaluation.tier4.jp/evaluation/reports/9058babd-3979-555b-9559-48ef2ca1d3f4?project_id=prd_jt
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.