Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix functions related to pull over lanes #4857

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 3, 2023

Description

fix getPullOverLanes
When getting road lanes as pull over lanes, can not extend beyond route lane.

Related links

merge #4856 first

Tests performed

psim

https://evaluation.tier4.jp/evaluation/reports/984cdbf0-6f47-5adc-9105-72a0d9b0fa79?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 3, 2023
@kosuke55 kosuke55 marked this pull request as ready for review September 3, 2023 08:22
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!
if it's possible, not in this PR,
Could you add description about pull_over_lanes?
for example here?

@kosuke55 kosuke55 force-pushed the fix/pull_over_lanes branch 4 times, most recently from 8c32feb to e7c6108 Compare September 5, 2023 12:41
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/pull_over_lanes branch from 5b656dc to f991005 Compare September 5, 2023 17:27
@kosuke55 kosuke55 enabled auto-merge (squash) September 5, 2023 17:29
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.74% 🎉

Comparison is base (dec3d06) 15.13% compared to head (f991005) 15.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4857      +/-   ##
==========================================
+ Coverage   15.13%   15.87%   +0.74%     
==========================================
  Files        1578     1578              
  Lines      108872   109138     +266     
  Branches    33590    33782     +192     
==========================================
+ Hits        16474    17327     +853     
+ Misses      74304    73202    -1102     
- Partials    18094    18609     +515     
Flag Coverage Δ *Carryforward flag
differential 17.80% <0.00%> (?)
total 15.13% <ø> (+<0.01%) ⬆️ Carriedforward from dec3d06

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../scene_module/goal_planner/goal_planner_module.cpp 7.91% <0.00%> (+2.42%) ⬆️
...ner/src/utils/goal_planner/freespace_pull_over.cpp 13.11% <0.00%> (-0.22%) ⬇️
...ner/src/utils/goal_planner/geometric_pull_over.cpp 20.00% <0.00%> (-0.84%) ⬇️
...h_planner/src/utils/goal_planner/goal_searcher.cpp 1.97% <0.00%> (-0.03%) ⬇️
...planner/src/utils/goal_planner/shift_pull_over.cpp 3.57% <0.00%> (ø)
...avior_path_planner/src/utils/goal_planner/util.cpp 6.75% <0.00%> (+0.17%) ⬆️
planning/route_handler/src/route_handler.cpp 27.00% <0.00%> (+2.88%) ⬆️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit 318cddb into main Sep 6, 2023
@kosuke55 kosuke55 deleted the fix/pull_over_lanes branch September 6, 2023 09:01
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 7, 2023
…utowarefoundation#4857)

* fix(behavior_path_planner): fix functions related to pull over lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add buffer

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add comments

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…utowarefoundation#4857)

* fix(behavior_path_planner): fix functions related to pull over lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add buffer

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add comments

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
…utowarefoundation#4857)

* fix(behavior_path_planner): fix functions related to pull over lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add buffer

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add comments

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants