-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix functions related to pull over lanes #4857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
if it's possible, not in this PR,
Could you add description about pull_over_lanes
?
for example here?
8c32feb
to
e7c6108
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
5b656dc
to
f991005
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4857 +/- ##
==========================================
+ Coverage 15.13% 15.87% +0.74%
==========================================
Files 1578 1578
Lines 108872 109138 +266
Branches 33590 33782 +192
==========================================
+ Hits 16474 17327 +853
+ Misses 74304 73202 -1102
- Partials 18094 18609 +515
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…utowarefoundation#4857) * fix(behavior_path_planner): fix functions related to pull over lanes Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add buffer Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add comments Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…utowarefoundation#4857) * fix(behavior_path_planner): fix functions related to pull over lanes Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add buffer Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add comments Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…utowarefoundation#4857) * fix(behavior_path_planner): fix functions related to pull over lanes Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add buffer Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add comments Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
fix getPullOverLanes
When getting road lanes as pull over lanes, can not extend beyond route lane.
Related links
merge #4856 first
Tests performed
psim
https://evaluation.tier4.jp/evaluation/reports/984cdbf0-6f47-5adc-9105-72a0d9b0fa79?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.