Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/safety_check_for_start_goal_planner #847

Conversation

kyoichi-sugahara
Copy link

@kyoichi-sugahara kyoichi-sugahara commented Sep 18, 2023

Description

WIP

PR to launcher should be merged first

cherry-pick below PRs

autowarefoundation#4691
autowarefoundation#4669
autowarefoundation#4742
autowarefoundation#4804
autowarefoundation#4859
autowarefoundation#4873
autowarefoundation#4953
autowarefoundation#5002

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kyoichi-sugahara and others added 8 commits September 18, 2023 13:02
… used by start and goal planner (autowarefoundation#4804)

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… in goal_planner (autowarefoundation#4859)

add vehicle_info_

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… for start/goal planner (autowarefoundation#4873)

* add safety check for start/goal planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix typo

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* update comments

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add const

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix empty check

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>
…y check against dynamic obstacles (autowarefoundation#4892)

* visualize debug info for safety check

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
…owarefoundation#4953)

* add process on entry in start_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete description

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…er approval in manual mode (autowarefoundation#4927)

* add feature of stop after approval for goal_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* insert stop point after approval

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…ore approval (autowarefoundation#5007)

* fix condition when collision detected before approval

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…owarefoundation#5002)

* define hysteresis_factor_expand_rate

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add hysteresis_factor_expand_rate in SafetyCheckParams

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* style(pre-commit): autofix

* revert unnecessary change

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kyoichi-sugahara
Copy link
Author

cherry-pick in this PR

@kosuke55 kosuke55 deleted the feat/sugahara/update_start_goal_planner_v0.10.1 branch September 25, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant