-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_path_planner): add vehicle_info_ as member variable in goal_planner #4859
refactor(behavior_path_planner): add vehicle_info_ as member variable in goal_planner #4859
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4859 +/- ##
==========================================
- Coverage 15.10% 15.10% -0.01%
==========================================
Files 1576 1577 +1
Lines 108538 108588 +50
Branches 33316 33339 +23
==========================================
+ Hits 16395 16397 +2
- Misses 74266 74312 +46
- Partials 17877 17879 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… in goal_planner (autowarefoundation#4859) add vehicle_info_ Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… in goal_planner (autowarefoundation#4859) add vehicle_info_ Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… in goal_planner (autowarefoundation#4859) add vehicle_info_ Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
… in goal_planner (autowarefoundation#4859) add vehicle_info_ Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Description
This member variable is necessary to for safety check feature in goal_planner module.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.