Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): add vehicle_info_ as member variable in goal_planner #4859

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

This member variable is necessary to for safety check feature in goal_planner module.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 3, 2023
@kyoichi-sugahara kyoichi-sugahara added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Sep 3, 2023
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 1.01% and project coverage change: -0.01% ⚠️

Comparison is base (c03fb2f) 15.10% compared to head (cbb67bd) 15.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4859      +/-   ##
==========================================
- Coverage   15.10%   15.10%   -0.01%     
==========================================
  Files        1576     1577       +1     
  Lines      108538   108588      +50     
  Branches    33316    33339      +23     
==========================================
+ Hits        16395    16397       +2     
- Misses      74266    74312      +46     
- Partials    17877    17879       +2     
Flag Coverage Δ *Carryforward flag
differential 13.03% <1.01%> (?)
total 15.11% <ø> (+<0.01%) ⬆️ Carriedforward from c03fb2f

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ic_parallel_parking/geometric_parallel_parking.hpp 16.66% <0.00%> (-3.34%) ⬇️
...nner/utils/goal_planner/pull_over_planner_base.hpp 14.28% <ø> (ø)
..._safety_checker/path_safety_checker_parameters.hpp 50.00% <ø> (+7.14%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 5.91% <0.00%> (+0.09%) ⬆️
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...ner/src/utils/goal_planner/freespace_pull_over.cpp 13.11% <0.00%> (ø)
...ner/src/utils/goal_planner/geometric_pull_over.cpp 20.00% <0.00%> (-0.84%) ⬇️
...planner/src/utils/goal_planner/shift_pull_over.cpp 3.57% <0.00%> (-0.04%) ⬇️
...rc/utils/path_safety_checker/objects_filtering.cpp 0.00% <0.00%> (ø)
...ing/behavior_path_planner/src/utils/path_utils.cpp 14.65% <ø> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyoichi-sugahara kyoichi-sugahara merged commit 3ac89a1 into autowarefoundation:main Sep 4, 2023
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 5, 2023
… in goal_planner (autowarefoundation#4859)

add vehicle_info_

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
… in goal_planner (autowarefoundation#4859)

add vehicle_info_

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 18, 2023
… in goal_planner (autowarefoundation#4859)

add vehicle_info_

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
… in goal_planner (autowarefoundation#4859)

add vehicle_info_

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara deleted the feat/add_vehicle_info_as_member_variable branch September 27, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants